New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1822924: The snapshot backup must be requested from a single endpoint not multiple #304
Bug 1822924: The snapshot backup must be requested from a single endpoint not multiple #304
Conversation
/hold The backup script also need fixing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
etcdctl snapshot save ${SNAPSHOT_FILE} |
I thought the original issue reported by @hexfusion needed changes in the backup script and not here.
Infact if I am reading this right, the restore command does not read(and hence need) |
259bd88
to
552ab4c
Compare
/hold cancel |
@retroflexer: This pull request references Bugzilla bug 1822924, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/test e2e-aws-disruptive |
/test e2e-metal-ipi |
/ltgm |
/lgtm |
/test e2e-gcp |
/hold @retroflexer a nit, can you please reword the commit,? It is still pointing at restore pod. Thanks |
552ab4c
to
3e10dbc
Compare
/hold cancel |
/retest |
@retroflexer: This pull request references Bugzilla bug 1822924, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alaypatel07, retroflexer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@retroflexer: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@retroflexer: All pull requests linked via external trackers have merged: openshift/cluster-etcd-operator#304. Bugzilla bug 1822924 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The snapshot backup command must be requested for a single endpoint, and not multiple endpoints. The etcd versions of 3.3.x were forgiving but bumping to etcd to 3.4.7 fails with an error when ETCDCTL_ENDPOINTS contain multiple members.