Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1822924: The snapshot backup must be requested from a single endpoint not multiple #304

Merged
merged 1 commit into from Apr 11, 2020
Merged

Bug 1822924: The snapshot backup must be requested from a single endpoint not multiple #304

merged 1 commit into from Apr 11, 2020

Conversation

retroflexer
Copy link
Contributor

@retroflexer retroflexer commented Apr 9, 2020 •
edited

The snapshot backup command must be requested for a single endpoint, and not multiple endpoints. The etcd versions of 3.3.x were forgiving but bumping to etcd to 3.4.7 fails with an error when ETCDCTL_ENDPOINTS contain multiple members.

@retroflexer
Copy link
Contributor Author

/hold

The backup script also need fixing.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2020
alaypatel07
alaypatel07 suggested changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@alaypatel07 alaypatel07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cluster-etcd-operator/bindata/etcd/cluster-backup.sh

Line 69 in 259bd88

etcdctl snapshot save ${SNAPSHOT_FILE}

I thought the original issue reported by @hexfusion needed changes in the backup script and not here.

@alaypatel07
Copy link
Contributor

Infact if I am reading this right, the restore command does not read(and hence need) endpoints flag

https://github.com/etcd-io/etcd/blob/34bd797e6754911ee540e8c87f708f88ffe89f37/etcdctl/ctlv3/command/snapshot_command.go#L139-L138

@retroflexer retroflexer changed the title The snapshot restore must be requested for one selected node not multiple The snapshot backup must be requested from a single endpoint not multiple Apr 10, 2020
@retroflexer
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2020
@retroflexer retroflexer changed the title The snapshot backup must be requested from a single endpoint not multiple Bug 1822924: The snapshot backup must be requested from a single endpoint not multiple Apr 10, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 10, 2020
@openshift-ci-robot
Copy link

@retroflexer: This pull request references Bugzilla bug 1822924, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1822924: The snapshot backup must be requested from a single endpoint not multiple

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@retroflexer
Copy link
Contributor Author

/retest

@retroflexer
Copy link
Contributor Author

/test e2e-aws-disruptive

@alaypatel07
Copy link
Contributor

/test e2e-metal-ipi

@alaypatel07
Copy link
Contributor

/ltgm

@alaypatel07
Copy link
Contributor

/lgtm

@alaypatel07
Copy link
Contributor

/test e2e-gcp

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 10, 2020
@alaypatel07
Copy link
Contributor

/hold

@retroflexer a nit, can you please reword the commit,? It is still pointing at restore pod. Thanks

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2020
@retroflexer
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2020
@retroflexer
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

@retroflexer: This pull request references Bugzilla bug 1822924, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1822924: The snapshot backup must be requested from a single endpoint not multiple

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alaypatel07
alaypatel07 approved these changes Apr 11, 2020
View reviewed changes
Copy link
Contributor

@alaypatel07 alaypatel07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alaypatel07, retroflexer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 11, 2020 •
edited

@retroflexer: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-azure 3e10dbc link /test e2e-azure
ci/prow/e2e-aws-disruptive 3e10dbc link /test e2e-aws-disruptive

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit bc4b68d into openshift:master Apr 11, 2020
@openshift-ci-robot
Copy link

@retroflexer: All pull requests linked via external trackers have merged: openshift/cluster-etcd-operator#304. Bugzilla bug 1822924 has been moved to the MODIFIED state.

In response to this:

Bug 1822924: The snapshot backup must be requested from a single endpoint not multiple

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@retroflexer retroflexer deleted the fix-restore-pod-endpoints branch June 2, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaypatel07 alaypatel07 alaypatel07 approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@alaypatel07 alaypatel07

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@retroflexer @alaypatel07 @openshift-ci-robot @openshift-bot @openshift-merge-robot