Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1826724: Fix openshift_etcd_operator_build_info metric #311

Merged
merged 3 commits into from Apr 22, 2020
Merged

Bug 1826724: Fix openshift_etcd_operator_build_info metric #311

merged 3 commits into from Apr 22, 2020

Conversation

mfojtik
Copy link
Member

@mfojtik mfojtik commented Apr 15, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2020
@mfojtik
Copy link
Member Author

mfojtik commented Apr 15, 2020

/retest

@alaypatel07
Copy link
Contributor

dug a little into https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-etcd-operator/311/pull-ci-openshift-cluster-etcd-operator-master-e2e-gcp/1173

CEO bootstrapped successfully, etcd is healthy. I found etcd-bootstrap member remove event[1] and co/etcd status[2] as expected.

  1. https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-etcd-operator/311/pull-ci-openshift-cluster-etcd-operator-master-e2e-gcp/1173/artifacts/e2e-gcp/events.json
  2. https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-etcd-operator/311/pull-ci-openshift-cluster-etcd-operator-master-e2e-gcp/1173/artifacts/e2e-gcp/clusteroperators.json

@mfojtik
Copy link
Member Author

mfojtik commented Apr 16, 2020

/retest

2 similar comments
@mfojtik
Copy link
Member Author

mfojtik commented Apr 16, 2020

/retest

@hexfusion
Copy link
Contributor

/retest

@hexfusion
Copy link
Contributor

the server is currently unable to handle the request (get imagestreams.image.openshift.io pipeline
 flakes

/retest

@mfojtik
Copy link
Member Author

mfojtik commented Apr 17, 2020

/retest

@mfojtik
Copy link
Member Author

mfojtik commented Apr 17, 2020

/retest

azure flakz

@hexfusion
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@hexfusion
Copy link
Contributor

/skip
/test e2e-gcp-upgrade

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@hexfusion
Copy link
Contributor

/skip

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020
@mfojtik mfojtik changed the title bump library-go to fix version Bug 1826724: Fix openshift_etcd_operator_build_info metric Apr 22, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 22, 2020
@openshift-ci-robot
Copy link

@mfojtik: This pull request references Bugzilla bug 1826724, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1826724: Fix openshift_etcd_operator_build_info metric

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
bump(*): vendor update
b59a0fa 
* openshift/api@6c7683d5: Add missing enum validations
* openshift/api@aaa7306c: operator/ingress: add dnsrecord type
* openshift/api@efc87562: dnsrecord: docs updates
* openshift/api@8b9591dd: fix dns record type and add enum validation
* openshift/api@d6a9b968: flatten ingress operator group package
* openshift/api@802801bf: add min validations to strings and arrays
* openshift/api@ae8fb7f2: recordTTL doc fixup
* openshift/api@62288b17: remove redundant optional tags
* openshift/api@f224e742: update platform status with ibmcloud platform
* openshift/api@7295f293: Migrate to openshift/build-machinery-go
* openshift/api@001335d6: Bump: github.com/openshift/build-machinery-go
* openshift/api@f161ef94: Ignore generated binary
* openshift/api@224bbd5c: Remove Travis in favour of openshift/release#7411
* openshift/api@a39d78eb: DEVEXP-544: Add Affinity to the image registry CRD
* openshift/api@60852beb: Update go.mod to use v0.18.0-beta.2
* openshift/api@9ba290b1: go mod tidy & go mod vendor
* openshift/api@fdf269f9: Update generated protobuf
* openshift/api@97458d9b: Add OmitEmpty to all optional fields
* openshift/api@6248d484: Fixes openshift#545: Fix copyright in LICENSE file
* openshift/api@42b07479: adds OAuthAPIServerStatus that holds status specific only to openshift-apiserver binary
* openshift/api@53ccb04e: add build status reasons for fetch image source and manage dockerfile failures
* openshift/api@0bb4670f: generated
* openshift/api@cc711f19: remove the service catalog crds
* openshift/api@49cc7219: mark service catalog types DEPRECATED
* openshift/api@ea026483: fix(codegen): add missing client tag to operatorhub config type
* openshift/api@5bc421a4: Use fedora:31 since we require go 1.13
* openshift/api@987aea5d: update generated
* openshift/api@d767ddd3: Add omitempty tags to Route resources.
* openshift/api@b6c626c7: Update go.mod to use v0.18.0
* openshift/api@acf858d1: go mod tidy & go mod vendor
* openshift/api@c028dd2a: operator: add config operator type
* openshift/client-go@c10ab197: Update go.mod to use v0.18.0-beta.2
* openshift/client-go@e7fa42a1: make generate
* openshift/client-go@bf14bfa8: Fix build errors (adding context and changing buildConfig Instantiate call)
* openshift/client-go@2ed83913: chore(modules): bump openshift/api version
* openshift/client-go@f7baeb99: chore(codegen): generate operatorhub config client
* openshift/client-go@3fd9fa39: Bump to k8s v0.18.0 tag
* openshift/library-go@fa68bbd7: apiserver observers: add observer mirrors writing to apiServerArguments
* openshift/library-go@d4ca95bf: introduces UnionRevisionLabelPodDeployer that returns a unified state from multiple distinct deployers.
* openshift/library-go@c466506f: Update go.mod to use v0.18.0-beta.2
* openshift/library-go@4a44f950: Fix compilation errors (mostly context.TODOs)
* openshift/library-go@da5c7119: Non-client related compile fixes
* openshift/library-go@5807a73a: Fix oauthServiceAccount client interface to include contexts
* openshift/library-go@d19e3500: Update metric query helpers to include context
* openshift/library-go@67fcc94d: adds revision controller to APIServerControllerSet
* openshift/library-go@d429589a: encryption: make encryption informer wrapper look closer to real informer
* openshift/library-go@0b9944ec: encryption: move controllers to use context
* openshift/library-go@1b0c1e53: encryption: migrate controllers to factory
* openshift/library-go@d20dc01b: encryption: fix unionrevisionedpod to match Deployer interface
* openshift/library-go@478f7ba9: Add CSIDriver to resourceread and resourceapply
* openshift/library-go@0f41c809: factory: add WithSyncDegradedOnError that allows handling degraded for simple sync()
* openshift/library-go@b3403f52: Update to k8s v0.18.0 tag
* openshift/library-go@3a0b429c: adds encryption controllers to apiservercontrollerset
* openshift/library-go@910d1724: moves DeploymentNodeProvider that returns the node list from nodes matching the node selector of a Deployment
* openshift/library-go@45a3babd: adds encryption.Provider that abstracts external dependencies and preconditions that need to be dynamic during a downgra
* openshift/library-go@f24f9c0d: observer: fix index error in corsobserver tests
* openshift/library-go@0755af61: configobserver: add WithPrefix to allow setting separate subtrees
* openshift/library-go@21d275b6: Fix StorageClasses comparison
* openshift/library-go@ddf47476: add WithCustomInstaller method to Builder interface
* openshift/library-go@4c47103d: Fix SA token sync
* openshift/library-go@a39bf282: fileObserver: detect file existence when adding reactor
* openshift/library-go@b833546a: Fix serving-certs race for controller's NewCommand*
* openshift/library-go@609e1511: Fix ApplySecret for type changes
* openshift/library-go@114736d4: cmdbuilder: add WithVersion() that reports version metrics of binary
* openshift/library-go@eca66601: cmd: add WithVersion to StartController
@mfojtik
react to library-go bump changes
2a9aa17
@mfojtik
operator: restore etcd service when deleted
fa5083d
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2020 •
edited

@mfojtik: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-disruptive fa5083d link /test e2e-aws-disruptive
ci/prow/e2e-azure fa5083d link /test e2e-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hexfusion
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hexfusion
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 22, 2020
@openshift-ci-robot
Copy link

@hexfusion: This pull request references Bugzilla bug 1826724, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 22, 2020
@hexfusion
Copy link
Contributor

/test e2e-gcp

@openshift-merge-robot openshift-merge-robot merged commit b58a378 into openshift:master Apr 22, 2020
@openshift-ci-robot
Copy link

@mfojtik: All pull requests linked via external trackers have merged: openshift/cluster-etcd-operator#311. Bugzilla bug 1826724 has been moved to the MODIFIED state.

In response to this:

Bug 1826724: Fix openshift_etcd_operator_build_info metric

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced May 26, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaypatel07 alaypatel07 Awaiting requested review from alaypatel07

@sttts sttts Awaiting requested review from sttts

Assignees

@hexfusion hexfusion

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mfojtik @alaypatel07 @hexfusion @openshift-bot @openshift-ci-robot @openshift-merge-robot