Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1825667: pkg/cmd/render: add support for s390 and s390x arch #317

Merged
merged 1 commit into from Apr 30, 2020

Conversation

hexfusion
Copy link
Contributor

This PR replaces tolerance for upstream etcd unsupported architectures s390 and s390x. Because ETCD_UNSUPPORTED_ARCH should only be set in ENV if it is defined we took the liberty of making the env: section of the bootstrap static pod spec more inline with what we do with the etcdenvvar controller.

This will make future changes to runtime env's much easier to add and manage.

@hexfusion hexfusion changed the title pkg/cmd/render: add support for s390 and s390x arch [wip] pkg/cmd/render: add support for s390 and s390x arch Apr 21, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 21, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2020
@hexfusion hexfusion changed the title [wip] pkg/cmd/render: add support for s390 and s390x arch [wip]Bug 1825667: pkg/cmd/render: add support for s390 and s390x arch Apr 21, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/medium bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 21, 2020
@openshift-ci-robot
Copy link

@hexfusion: This pull request references Bugzilla bug 1825667, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

[wip]Bug 1825667: pkg/cmd/render: add support for s390 and s390x arch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion
Copy link
Contributor Author

/test e2e-aws

infra flake

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion hexfusion changed the title [wip]Bug 1825667: pkg/cmd/render: add support for s390 and s390x arch Bug 1825667: pkg/cmd/render: add support for s390 and s390x arch Apr 21, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 21, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed bugzilla/medium labels Apr 29, 2020
@retroflexer
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, retroflexer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 30, 2020

@hexfusion: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-azure 97a975e link /test e2e-azure
ci/prow/e2e-metal-ipi 97a975e link /test e2e-metal-ipi
ci/prow/e2e-aws-disruptive 97a975e link /test e2e-aws-disruptive

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7b7e544 into openshift:master Apr 30, 2020
@openshift-ci-robot
Copy link

@hexfusion: All pull requests linked via external trackers have merged: openshift/cluster-etcd-operator#317. Bugzilla bug 1825667 has been moved to the MODIFIED state.

In response to this:

Bug 1825667: pkg/cmd/render: add support for s390 and s390x arch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Prashanth684 added a commit to Prashanth684/cluster-etcd-operator that referenced this pull request May 5, 2020
This is a backport of openshift#317 with a few minor changes that were needed for 4.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants