Bug 1821286: Unstarted members cannot be blank in the log/event messages #318
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
retroflexer
force-pushed
the
fix-unstarted-member-name
branch
from
ed09d48
to
98a026d
Compare
retroflexer
force-pushed
the
fix-unstarted-member-name
branch
3 times, most recently
from
63b93c2
to
6b02ba5
Compare
retroflexer
changed the title
openshift-ci-robot
added
bugzilla/high
and removed
do-not-merge/work-in-progress
|
@retroflexer: This pull request references Bugzilla bug 1821286, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/invalid-bug
|
@retroflexer: This pull request references Bugzilla bug 1821286, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
retroflexer
force-pushed
the
fix-unstarted-member-name
branch
from
6b02ba5
to
8b7b2d3
Compare
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/test e2e-azure |
|
lgtm, leaving the tag for @hexfusion if he has comments. Thanks |
There was a problem hiding this comment.
@retroflexer, in general, I think we can define an unstarted member as something like
fmt.Sprintf("UNSTARTED-NAME-PENDING.%s", hostname)
making it more clear why we see the naming?
I agree. But my only apprehension is that with IPv6 it could become very lengthy and unreadable. |
retroflexer
force-pushed
the
fix-unstarted-member-name
branch
from
8b7b2d3
to
eca6a3c
Compare
openshift-ci-robot
added
bugzilla/severity-high
retroflexer
force-pushed
the
fix-unstarted-member-name
branch
from
eca6a3c
to
a8d3573
Compare
retroflexer
force-pushed
the
fix-unstarted-member-name
branch
from
a8d3573
to
cdade9b
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hexfusion, retroflexer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test e2e-aws |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@retroflexer: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/skip |
|
@retroflexer: All pull requests linked via external trackers have merged: openshift/cluster-etcd-operator#290, openshift/cluster-etcd-operator#318. Bugzilla bug 1821286 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
etcd doesn't store the name for the unstarted members. It is initialized only when the etcd is started. So, when reporting unstarted members, currently the message appears with blank name, which can be confusing. This PR attempts to fill the name with hostname (or IP address) extracted from peer URL for the unstarted members.