Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] test deadlock #345

Closed
wants to merge 7 commits into from
Closed

Conversation

hexfusion
Copy link
Contributor

@hexfusion hexfusion commented May 12, 2020

POTENTIAL DEADLOCK:
Previous place where the lock was grabbed
goroutine 1106 lock 0xc00074ff58
github.com/openshift/cluster-etcd-operator@/pkg/etcdcli/etcdcli.go:106 etcdcli.(*etcdClientGetter).getEtcdClient ??? <<<<<
github.com/openshift/cluster-etcd-operator@/pkg/etcdcli/etcdcli.go:292 etcdcli.(*etcdClientGetter).UnhealthyMembers ???
github.com/openshift/cluster-etcd-operator@/pkg/operator/etcdmemberipmigrator/etcdmemberipmigrator.go:90 etcdmemberipmigrator.(*EtcdMemberIPMigrator).reconcileMembers ???
github.com/openshift/cluster-etcd-operator@/pkg/operator/etcdmemberipmigrator/etcdmemberipmigrator.go:66 etcdmemberipmigrator.(*EtcdMemberIPMigrator).sync ???
github.com/openshift/library-go@v0.0.0-20200427130628-9b02543ac833/pkg/controller/factory/base_controller.go:139 factory.(*baseController).reconcile ???
github.com/openshift/library-go@v0.0.0-20200427130628-9b02543ac833/pkg/controller/factory/base_controller.go:179 factory.(*baseController).processNextWorkItem ???
github.com/openshift/library-go@v0.0.0-20200427130628-9b02543ac833/pkg/controller/factory/base_controller.go:130 factory.(*baseController).runWorker.func1 ???

Have been trying to lock it again for more than 30s
goroutine 1154 lock 0xc00074ff58
github.com/openshift/cluster-etcd-operator@/pkg/etcdcli/etcdcli.go:106 etcdcli.(*etcdClientGetter).getEtcdClient ??? <<<<<
github.com/openshift/cluster-etcd-operator@/pkg/etcdcli/etcdcli.go:249 etcdcli.(*etcdClientGetter).MemberList ???
github.com/openshift/cluster-etcd-operator@/pkg/operator/bootstrapteardown/bootstrap_teardown_controller.go:135 bootstrapteardown.(*BootstrapTeardownController).canRemoveEtcdBootstrap ???
github.com/openshift/cluster-etcd-operator@/pkg/operator/bootstrapteardown/bootstrap_teardown_controller.go:69 bootstrapteardown.(*BootstrapTeardownController).removeBootstrap ???
github.com/openshift/cluster-etcd-operator@/pkg/operator/bootstrapteardown/bootstrap_teardown_controller.go:44 bootstrapteardown.(*BootstrapTeardownController).sync ???
github.com/openshift/library-go@v0.0.0-20200427130628-9b02543ac833/pkg/controller/factory/base_controller.go:139 factory.(*baseController).reconcile ???
github.com/openshift/library-go@v0.0.0-20200427130628-9b02543ac833/pkg/controller/factory/base_controller.go:179 factory.(*baseController).processNextWorkItem ???
github.com/openshift/library-go@v0.0.0-20200427130628-9b02543ac833/pkg/controller/factory/base_controller.go:130 factory.(*baseController).runWorker.func1 ???

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2020
@hexfusion hexfusion changed the title test deadlock [wip] test deadlock May 12, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2020
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2020
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2020
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci-robot
Copy link

@hexfusion: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-upgrade 25fb51d link /test e2e-gcp-upgrade
ci/prow/e2e-gcp 25fb51d link /test e2e-gcp
ci/prow/e2e-metal-ipi 25fb51d link /test e2e-metal-ipi
ci/prow/e2e-aws-disruptive 25fb51d link /test e2e-aws-disruptive
ci/prow/e2e-azure 25fb51d link /test e2e-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hexfusion
Copy link
Contributor Author

work finished up in #343

@hexfusion hexfusion closed this May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants