Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1842431: cluster-backup.sh: error if script dependencies are not met #371

Merged
merged 1 commit into from Jun 17, 2020
Merged

Bug 1842431: cluster-backup.sh: error if script dependencies are not met #371

merged 1 commit into from Jun 17, 2020

Conversation

hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Jun 4, 2020 •
edited

This PR adds error handling to assist user in understanding that the backup script is not located on a node that is able to perform backup. Also updated the script to be valid against shellcheck.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2020
@hexfusion hexfusion added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 4, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2020
@hexfusion hexfusion changed the title cluster-backup.sh: error if script dependencies are not met Bug 1842431: cluster-backup.sh: error if script dependencies are not met Jun 5, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 5, 2020
@openshift-ci-robot
Copy link

@hexfusion: This pull request references Bugzilla bug 1842431, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1842431: cluster-backup.sh: error if script dependencies are not met

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion
Copy link
Contributor Author

/retest

@retroflexer
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2020
@hexfusion
Copy link
Contributor Author

/hold
this is good timing to fix DR tests

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2020
@retroflexer
Copy link
Contributor

/lgtm

@hexfusion
Copy link
Contributor Author

/test all

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2020
@hexfusion
Copy link
Contributor Author

/test all

1 similar comment
@hexfusion
Copy link
Contributor Author

/test all

@retroflexer
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2020
@hexfusion
cluster-backup.sh: error if script dependencies are not met
087398a 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2020
@retroflexer
Copy link
Contributor

/lgtm

@openshift-cherrypick-robot
Copy link

@hexfusion: once the present PR merges, I will cherry-pick it on top of release-4,5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4,5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion
Copy link
Contributor Author

/cherry-pick release-4,4

@openshift-cherrypick-robot
Copy link

@hexfusion: once the present PR merges, I will cherry-pick it on top of release-4,4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4,4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@hexfusion
Copy link
Contributor Author

/test e2e-gcp

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e2b9445 into openshift:master Jun 17, 2020
@openshift-ci-robot
Copy link

@hexfusion: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:

In response to this:

Bug 1842431: cluster-backup.sh: error if script dependencies are not met

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@hexfusion: cannot checkout release-4,5: error checking out release-4,5: exit status 1. output: error: pathspec 'release-4,5' did not match any file(s) known to git.

In response to this:

/cherry-pick release-4,5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@hexfusion: cannot checkout release-4,4: error checking out release-4,4: exit status 1. output: error: pathspec 'release-4,4' did not match any file(s) known to git.

In response to this:

/cherry-pick release-4,4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion
Copy link
Contributor Author

/cherry-pick release-4.5
/cherry-pick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 17, 2020
Merged
@openshift-cherrypick-robot
Copy link

@hexfusion: new pull request created: #378

In response to this:

/cherry-pick release-4.5
/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 17, 2020 •
edited

@hexfusion: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-disruptive 087398a link /test e2e-aws-disruptive
ci/prow/unit 259e21a link /test unit
ci/prow/e2e-azure 259e21a link /test e2e-azure
ci/prow/e2e-aws 259e21a link /test e2e-aws
ci/prow/verify-deps 259e21a link /test verify-deps
ci/prow/e2e-gcp 259e21a link /test e2e-gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ironcladlou
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot
Copy link

@ironcladlou: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion hexfusion deleted the fix-backup branch June 18, 2020 13:06
@openshift-ci-robot openshift-ci-robot mentioned this pull request Jun 18, 2020
Merged
@ironcladlou
Copy link
Contributor

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

@ironcladlou: #371 failed to apply on top of branch "release-4.4":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	bindata/etcd/cluster-backup.sh
M	pkg/operator/etcd_assets/bindata.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/operator/etcd_assets/bindata.go
CONFLICT (content): Merge conflict in pkg/operator/etcd_assets/bindata.go
Auto-merging bindata/etcd/cluster-backup.sh
CONFLICT (content): Merge conflict in bindata/etcd/cluster-backup.sh
Patch failed at 0001 cluster-backup.sh: error if script dependencies are not met

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ironcladlou ironcladlou mentioned this pull request Jun 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironcladlou ironcladlou ironcladlou left review comments

@retroflexer retroflexer Awaiting requested review from retroflexer

Assignees

@retroflexer retroflexer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@hexfusion @openshift-ci-robot @retroflexer @openshift-cherrypick-robot @openshift-bot @ironcladlou @openshift-merge-robot