Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how etcd's TLS assets are managed #405

Merged
merged 1 commit into from Aug 11, 2020

Conversation

markmc
Copy link
Contributor

@markmc markmc commented Jul 27, 2020

I found all of this quite bewildering to keep straight in my head, so I figured I'd try to write it down.

@hexfusion
Copy link
Contributor

@markmc this is an amazing amount of work. Thank you, will review soon.

@cgwalters
Copy link
Member

I happened to come across this when I was trying to figure out how the etcd static pod manifest is installed. Agreed, awesome work! I personally would merge this as is and do other changes as followups to avoid losing it.

It seems though the second half in particular is more about the architecture, and isn't specific to certs; maybe move that into a separate design.md?

@hexfusion
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, markmc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2020
@hexfusion
Copy link
Contributor

yeah let's merge marks work and fine-tune from here thanks again.

@hexfusion
Copy link
Contributor

/retest

@hexfusion
Copy link
Contributor

/skip

1 similar comment
@hexfusion
Copy link
Contributor

/skip

@openshift-ci-robot
Copy link

@markmc: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-azure 3afb9ed link /test e2e-azure
ci/prow/e2e-aws-disruptive 3afb9ed link /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hexfusion
Copy link
Contributor

/skip

@openshift-merge-robot openshift-merge-robot merged commit c6c63df into openshift:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants