New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how etcd's TLS assets are managed #405
Document how etcd's TLS assets are managed #405
Conversation
@markmc this is an amazing amount of work. Thank you, will review soon. |
I happened to come across this when I was trying to figure out how the etcd static pod manifest is installed. Agreed, awesome work! I personally would merge this as is and do other changes as followups to avoid losing it. It seems though the second half in particular is more about the architecture, and isn't specific to certs; maybe move that into a separate |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hexfusion, markmc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yeah let's merge marks work and fine-tune from here thanks again. |
/retest |
/skip |
1 similar comment
/skip |
@markmc: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/skip |
I found all of this quite bewildering to keep straight in my head, so I figured I'd try to write it down.