Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1855569: vendor: bump #411

Merged
merged 1 commit into from Jul 31, 2020
Merged

Bug 1855569: vendor: bump #411

merged 1 commit into from Jul 31, 2020

Conversation

hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Jul 30, 2020 •
edited

This PR bumps library-go to latest and brings k8s to v0.19.0-rc.2 along with that comes a bump to etcd client 3.4.10.

Breaking[1] changes to etcd are only on server side.

[1] https://github.com/etcd-io/etcd/blob/master/CHANGELOG-3.4.md#breaking-changes

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2020
@ironcladlou
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2020
@hexfusion
Copy link
Contributor Author

gcp had bootstrap failure probably needs review.

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-etcd-operator/411/pull-ci-openshift-cluster-etcd-operator-master-e2e-gcp/1288814121789165568

/test e2e-gcp

@hexfusion
vendor: bump
bb7a538 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2020
@hexfusion
Copy link
Contributor Author

The issue was I had the wrong library-go sha that did not include Davids fix

@hexfusion
Copy link
Contributor Author

/test e2e-gcp-upgrade

@ironcladlou
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, ironcladlou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hexfusion,ironcladlou]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@hexfusion
Copy link
Contributor Author

/test e2e-gcp-upgrade

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 31, 2020 •
edited

@hexfusion: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-disruptive bb7a538 link /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hexfusion
Copy link
Contributor Author

/hold
upgrade needs looked at

/test e2e-gcp-upgrade

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2020
@hexfusion
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2020
@openshift-merge-robot openshift-merge-robot merged commit dcdea03 into openshift:master Jul 31, 2020
@hexfusion hexfusion changed the title vendor: bump Bug 1855702: vendor: bump Aug 18, 2020
@openshift-ci-robot
Copy link

@hexfusion: All pull requests linked via external trackers have merged: . Bugzilla bug 1855702 has been moved to the MODIFIED state.

In response to this:

Bug 1855702: vendor: bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion hexfusion changed the title Bug 1855702: vendor: bump Bug 1855569: vendor: bump Aug 21, 2020
@openshift-ci-robot
Copy link

@hexfusion: All pull requests linked via external trackers have merged: . Bugzilla bug 1855569 has been moved to the MODIFIED state.

In response to this:

Bug 1855569: vendor: bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@retroflexer retroflexer Awaiting requested review from retroflexer

Assignees

@ironcladlou ironcladlou

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hexfusion @ironcladlou @openshift-ci-robot @openshift-bot @openshift-merge-robot