Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1876091: Render bootstrap certificates #412

Merged
merged 1 commit into from Jul 31, 2020

Conversation

ironcladlou
Copy link
Contributor

@ironcladlou ironcladlou commented Jul 30, 2020

During render, generate the certificates necessary for the bootstrap member.

Update the bootstrap pod to use the rendered certificates.

After this change, the existing asynchronous client/server based bootstrap
certificate generation mechanism should be deleted.

Extracted from @markmc's work in #410.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2020
@ironcladlou
Copy link
Contributor Author

/retest

@ironcladlou
Copy link
Contributor Author

/retest

Render bootstrap certificates

During render, generate the certificates necessary for the bootstrap member.

Update the bootstrap pod to use the rendered certificates.

After this change, the existing asynchronous client/server based bootstrap
certificate generation mechanism should be deleted.
@ironcladlou ironcladlou changed the title WIP: render bootstrap certificates inline Render bootstrap certificates Jul 31, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2020
@ironcladlou
Copy link
Contributor Author

e2e should be a sufficient test here — the updated bootstrap member pod no longer refers to the certificates generated by the existing kubecsr process, so if we pivot it means our rendered certs were good enough to get us past bootstrap and the installer bits can be deleted (openshift/installer#3995) and additional refactoring can proceed.

@hexfusion
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, ironcladlou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hexfusion,ironcladlou]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ironcladlou added a commit to ironcladlou/installer that referenced this pull request Jul 31, 2020
The cluster-etcd-operator render command now handles bootstrap certificate
generation[1]. This patch deletes the now unused client/server bootstrap etcd
cert generation logic.

[1] openshift/cluster-etcd-operator#412
@openshift-merge-robot openshift-merge-robot merged commit 7e4568f into openshift:master Jul 31, 2020
vrutkovs pushed a commit to vrutkovs/installer that referenced this pull request Aug 6, 2020
The cluster-etcd-operator render command now handles bootstrap certificate
generation[1]. This patch deletes the now unused client/server bootstrap etcd
cert generation logic.

[1] openshift/cluster-etcd-operator#412
ironcladlou added a commit to ironcladlou/installer that referenced this pull request Sep 9, 2020
The cluster-etcd-operator render command now handles bootstrap certificate
generation[1]. This patch deletes the now unused client/server bootstrap etcd
cert generation logic.

[1] openshift/cluster-etcd-operator#412
@sdodson
Copy link
Member

sdodson commented Sep 9, 2020

/retitle Bug 1876091: Render bootstrap certificates

@openshift-ci-robot openshift-ci-robot changed the title Render bootstrap certificates Bug 1876091: Render bootstrap certificates Sep 9, 2020
@openshift-ci-robot
Copy link

@ironcladlou: Bugzilla bug 1876091 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

Bug 1876091: Render bootstrap certificates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jim-minter pushed a commit to jim-minter/installer that referenced this pull request Oct 31, 2020
The cluster-etcd-operator render command now handles bootstrap certificate
generation[1]. This patch deletes the now unused client/server bootstrap etcd
cert generation logic.

[1] openshift/cluster-etcd-operator#412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants