Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting cluster-backup and cluster-restore shell scripts as subcommands #415

Merged
merged 1 commit into from Aug 1, 2020
Merged

Converting cluster-backup and cluster-restore shell scripts as subcommands #415

merged 1 commit into from Aug 1, 2020

Conversation

retroflexer
Copy link
Contributor

@retroflexer retroflexer commented Jul 31, 2020 •
edited

Converting the bash scripts into Golang as subcommands to cluster-etcd-operator.

This supersedes the previous PR #398.

@retroflexer
Copy link
Contributor Author

/test e2e-aws

@ironcladlou
Copy link
Contributor

/approve
/retest

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2020
ironcladlou
ironcladlou reviewed Jul 31, 2020
View reviewed changes
pkg/cmd/backuprestore/restoreutils.go

// TODO: Wait for static pods to stop
// crictl ps equivalent??
time.Sleep(180 * time.Second)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll open a 4.6 blocker to improve the reliability of this check (e.g. through a runtime API call)

@ironcladlou
Copy link
Contributor

/lgtm

Thanks!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, retroflexer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

@retroflexer: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-azure 872a7c3 link /test e2e-azure
ci/prow/e2e-aws-disruptive 872a7c3 link /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 563f762 into openshift:master Aug 1, 2020
@retroflexer retroflexer deleted the backup-and-restore-subcommands branch August 1, 2020 12:35
@retroflexer retroflexer mentioned this pull request Aug 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironcladlou ironcladlou ironcladlou left review comments

@hexfusion hexfusion Awaiting requested review from hexfusion

Assignees

@ironcladlou ironcladlou

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@retroflexer @ironcladlou @openshift-ci-robot @openshift-bot @openshift-merge-robot