Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1850057: etcd-pod: Use ionice -c2 -n0 #418

Merged
merged 1 commit into from Sep 1, 2020

Conversation

cgwalters
Copy link
Member

This will have no currect effect with the default I/O scheduler
of mq-deadline, but I think it will help once we switch to bfq
as part of openshift/machine-config-operator#1946

This will have no currect effect with the default I/O scheduler
of `mq-deadline`, but I think it will help once we switch to `bfq`
as part of openshift/machine-config-operator#1946
@hexfusion
Copy link
Contributor

I just have one outstanding question regarding ionice. openshift/machine-config-operator#1957 (comment)

@cgwalters
Copy link
Member Author

Let's get this merged in combination with openshift/machine-config-operator#1957 ?

@cgwalters cgwalters changed the title etcd-pod: Use ionice -c2 -n0 Bug 1850057: etcd-pod: Use ionice -c2 -n0 Aug 25, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Aug 25, 2020
@openshift-ci-robot
Copy link

@cgwalters: This pull request references Bugzilla bug 1850057, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1850057: etcd-pod: Use ionice -c2 -n0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 25, 2020
@cgwalters
Copy link
Member Author

OK, this one should be good to go!

@hexfusion
Copy link
Contributor

/lgtm
/approve

@hexfusion
Copy link
Contributor

/retest

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 29, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@hexfusion
Copy link
Contributor

/refresh

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@cgwalters
Copy link
Member Author

/lgtm cancel
e2e-aws-disruptive is broken by the MCO dropping e-q-c looks like

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2020
@cgwalters
Copy link
Member Author

cgwalters commented Aug 31, 2020

e2e-aws-disruptive is broken by the MCO dropping e-q-c looks like

Filed openshift/openshift-tests#68 for that if someone wants to take it.

@cgwalters
Copy link
Member Author

Ah I think this is related to openshift/release@151d520 - e2e-aws-disruptive is obsolete.

@cgwalters
Copy link
Member Author

OK so now that I'm not off on a wild goose chase and am looking at the right e2e-disruptive test...hm, seems generally broken right now. There's not many runs for that test - do you all consider it blocking?

I'd like to get this one in because the BZ is tracking it.

@hexfusion
Copy link
Contributor

/refresh

@hexfusion
Copy link
Contributor

/test e2e-disruptive

@hexfusion
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hexfusion
Copy link
Contributor

/skip

@hexfusion
Copy link
Contributor

/refresh

@hexfusion
Copy link
Contributor

hexfusion commented Sep 1, 2020

do you all consider it blocking?

generally no and certainly not for this change.

@openshift-ci-robot
Copy link

@cgwalters: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-disruptive e1dae76 link /test e2e-aws-disruptive
ci/prow/e2e-disruptive e1dae76 link /test e2e-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7f809f6 into openshift:master Sep 1, 2020
@openshift-ci-robot
Copy link

@cgwalters: All pull requests linked via external trackers have merged:

Bugzilla bug 1850057 has been moved to the MODIFIED state.

In response to this:

Bug 1850057: etcd-pod: Use ionice -c2 -n0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants