New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1874552: *: migrate logger form klog to klog/v2 #432
Conversation
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
39012c7
to
9c2493d
Compare
I think the dep issue was because we were testing in go 1.13. But I am doing go mod in 1.14. /test verify-deps |
still reflects 1.13 going to wait a bit. |
/test verify-deps |
1 similar comment
/test verify-deps |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hexfusion, retroflexer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@hexfusion: This pull request references Bugzilla bug 1874552, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@hexfusion: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@hexfusion: All pull requests linked via external trackers have merged: Bugzilla bug 1874552 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR migrates the repo from klog v1 to klog v2 based on upstream change.[1],[2]
[1] kubernetes/kubernetes#89717
[2] https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/1602-structured-logging#proposal