Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IBM Cloud managed annotations to CVO manifests #498

Merged
merged 2 commits into from Nov 18, 2020
Merged

Add IBM Cloud managed annotations to CVO manifests #498

merged 2 commits into from Nov 18, 2020

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Nov 17, 2020

This matches openshift/enhancements#445 and does not change behavior.

@ironcladlou
Copy link
Contributor

@csrwng was the dependency bump intended and/or necessary for this change?

@csrwng
Copy link
Contributor Author

csrwng commented Nov 18, 2020

@csrwng was the dependency bump intended and/or necessary for this change?

@ironcladlou yes it was necessary so we could pick up the updated vendor/github.com/openshift/api/operator/v1/0000_12_etcd-operator_01_config.crd.yaml file from github.com/openshift/api

@csrwng
Copy link
Contributor Author

csrwng commented Nov 18, 2020

/retest

@hexfusion
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@hexfusion
Copy link
Contributor

/skip

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 18, 2020 •
edited

@csrwng: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-disruptive fbf0c0f link /test e2e-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 539906e into master Nov 18, 2020
@hexfusion hexfusion deleted the roks_profile branch November 18, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@retroflexer retroflexer Awaiting requested review from retroflexer

Assignees

@hexfusion hexfusion

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@csrwng @ironcladlou @hexfusion @openshift-ci-robot @openshift-bot @openshift-merge-robot