Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate manifests for single-node-developer cluster profile #505

Merged
merged 2 commits into from Dec 3, 2020
Merged

Annotate manifests for single-node-developer cluster profile #505

merged 2 commits into from Dec 3, 2020

Conversation

rkukura
Copy link
Contributor

@rkukura rkukura commented Dec 3, 2020

This partially implements phase 1 of
https://github.com/openshift/enhancements/blob/master/enhancements/single-node-developer-cluster-profile.md
and does not change behavior. Initially, all cluster-etcd-operator
manifests are included in the single-node-developer cluster profile.
Follow-on PRs may exclude any of these that are not needed in the
profile.

Robert Kukura added 2 commits December 3, 2020 11:56
This partially implements phase 1 of
https://github.com/openshift/enhancements/blob/master/enhancements/single-node-developer-cluster-profile.md
and does not change behavior. Initially, all cluster-etcd-operator
manifests are included in the single-node-developer cluster profile.
Follow-on PRs may exclude any of these that are not needed in the
profile.
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 3, 2020
@openshift-ci-robot
Copy link

Hi @rkukura. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion
Copy link
Contributor

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, rkukura

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2020
@hexfusion hexfusion removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 3, 2020
@openshift-merge-robot
Copy link
Contributor

@rkukura: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-disruptive c61cc5e link /test e2e-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkukura
Copy link
Contributor Author

rkukura commented Dec 3, 2020

/retest

@openshift-ci-robot
Copy link

@rkukura: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit a34fc49 into openshift:master Dec 3, 2020
@rkukura rkukura deleted the crc_profile branch December 3, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants