Bug 1925586: pkg/operator/metriccontroller: cleanup transports #534

hexfusion · 2021-01-22T14:38:12Z

4.7.0-0.nightly-2021-02-02-223803

4.7.0-0.nightly-2021-02-05-105159 CI

This PR

Closes #533

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>

hexfusion · 2021-01-25T17:27:51Z

this probably should go into library-go.

openshift-ci-robot · 2021-02-05T15:53:45Z

@hexfusion: This pull request references Bugzilla bug 1925586, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1925586: pkg/operator/metriccontroller: cleanup transports

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hexfusion · 2021-02-05T15:54:21Z

/bugzilla refresh

openshift-ci-robot · 2021-02-05T15:54:28Z

@hexfusion: This pull request references Bugzilla bug 1925586, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-02-05T15:58:01Z

@hexfusion: This pull request references Bugzilla bug 1925586, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1925586: pkg/operator/metriccontroller: cleanup transports

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-02-05T15:58:34Z

@hexfusion: This pull request references Bugzilla bug 1925586, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1925586: pkg/operator/metriccontroller: cleanup transports

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

retroflexer · 2021-02-05T16:05:15Z

/lgtm

openshift-ci-robot · 2021-02-05T16:05:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, retroflexer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [hexfusion]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hexfusion · 2021-02-05T16:10:05Z

/hold

I dont see the controller working in the test going to test over longer time to verify

hexfusion · 2021-02-05T16:15:56Z

/test e2e-agnostic

hexfusion · 2021-02-05T16:49:38Z

/test e2e-agnostic

hexfusion · 2021-02-05T18:53:26Z

/hold cancel

hexfusion · 2021-02-05T19:01:30Z

verified controller does eventually work as expected.

mbers are available, ci-ln-nlnbb2k-f76d1-bpvtd-master-1 is unhealthy" to "StaticPodsAvailable: 3 nodes are active; 3 nodes are at revision 3\nEtcdMembersAvailable: 3 members are available"
10m         Warning   EtcdLeaderChangeMetrics                deployment/etcd-operator                         Detected leader change increase of 1.25 over 5 minutes on "GCP"; disk metrics are: etcd-ci-ln-nlnbb2k-f76d1-bpvtd-master-1=0.005592000000000004,etcd-ci-ln-nlnbb2k-f76d1-bpvtd-master-2=0.012177766472868189,etcd-ci-ln-nlnbb2k-f76d1-bpvtd-master-0=0.003958805970149254
9m50s       Warning   EtcdLeaderChangeMetrics                deployment/etcd-operator                         Detected leader change increase of 1.25 over 5 minutes on "GCP"; disk metrics are: etcd-ci-ln-nlnbb2k-f76d1-bpvtd-master-1=0.00559200000000002,etcd-ci-ln-nlnbb2k-f76d1-bpvtd-master-2=0.012178015202446976,etcd-ci-ln-nlnbb2k-f76d1-bpvtd-master-0=0.003958805970149254
8m50s       Warning   EtcdLeaderChangeMetrics                deployment/etcd-operator                         Detected leader change increase of 1.25 over 5 minutes on "GCP"; disk metrics are: etcd-ci-ln-nlnbb2k-f76d1-bpvtd-master-1=0.005592000000000007,etcd-ci-ln-nlnbb2k-f76d1-bpvtd-master-2=0.012180588056987057,etcd-ci-ln-nlnbb2k-f76d1-bpvtd-master-0=0.003958805970149254
7m50s       Warning   EtcdLeaderChangeMetrics                deployment/etcd-operator                         Detected leader change increase of 1.25 over 5 minutes on "GCP"; disk metrics are: etcd-ci-ln-nlnbb2k-f76d1-bpvtd-master-1=0.005591999999999928,etcd-ci-ln-nlnbb2k-f76d1-bpvtd-master-2=0.012179093553078101,etcd-ci-ln-nlnbb2k-f76d1-bpvtd-master-0=0.006265454545454535

hexfusion · 2021-02-05T19:01:39Z

/retest

openshift-bot · 2021-02-05T19:20:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

hexfusion · 2021-02-05T21:04:08Z

Feb 5 19:58:06.060: FAIL: Connectivity to the load balancer was interrupted
unrelated

hexfusion · 2021-02-05T22:05:05Z

/test e2e-agnostic

openshift-bot · 2021-02-05T23:39:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-06T00:31:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2021-02-06T03:15:27Z

@hexfusion: All pull requests linked via external trackers have merged:

openshift/cluster-etcd-operator#534

Bugzilla bug 1925586 has been moved to the MODIFIED state.

In response to this:

Bug 1925586: pkg/operator/metriccontroller: cleanup transports

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hexfusion · 2021-02-06T03:19:10Z

/cherry-pick release-4.7

openshift-cherrypick-robot · 2021-02-06T03:19:49Z

@hexfusion: new pull request created: #537

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hexfusion · 2021-03-03T02:28:05Z

/cherry-pick release-4.6

openshift-cherrypick-robot · 2021-03-03T02:28:43Z

@hexfusion: new pull request created: #551

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hexfusion · 2021-03-16T03:38:59Z

/cherry-pick release-4.5

openshift-cherrypick-robot · 2021-03-16T03:39:29Z

@hexfusion: new pull request could not be created: failed to create pull request against openshift/cluster-etcd-operator#release-4.6 from head openshift-cherrypick-robot:cherry-pick-534-to-release-4.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.6 and openshift-cherrypick-robot:cherry-pick-534-to-release-4.6"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-03-16T03:39:36Z

@hexfusion: new pull request created: #555

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 22, 2021

openshift-ci-robot requested review from marun and retroflexer January 22, 2021 14:38

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2021

pkg/operator/metriccontroller: cleanup transport

32b41f5

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>

hexfusion force-pushed the cleanup-transport branch from c04005d to 32b41f5 Compare January 22, 2021 14:53

hexfusion changed the title ~~[wip] pkg/operator/metriccontroller: cleanup transports~~ pkg/operator/metriccontroller: cleanup transports Feb 5, 2021

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2021

hexfusion changed the title ~~pkg/operator/metriccontroller: cleanup transports~~ Bug 1925586: pkg/operator/metriccontroller: cleanup transports Feb 5, 2021

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 5, 2021

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 5, 2021

openshift-ci-robot assigned retroflexer Feb 5, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2021

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2021

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2021

openshift-merge-robot merged commit a759e80 into openshift:master Feb 6, 2021

hexfusion deleted the cleanup-transport branch February 6, 2021 03:17

openshift-cherrypick-robot mentioned this pull request Feb 6, 2021

[release-4.7] Bug 1925739: pkg/operator/metriccontroller: cleanup transports #537

Merged

openshift-cherrypick-robot mentioned this pull request Mar 3, 2021

[release-4.6] Bug 1934342: pkg/operator/metriccontroller: cleanup transports #551

Merged

openshift-cherrypick-robot mentioned this pull request Mar 16, 2021

[release-4.5] Bug 1939318: pkg/operator/metriccontroller: cleanup transports #555

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1925586: pkg/operator/metriccontroller: cleanup transports #534

Bug 1925586: pkg/operator/metriccontroller: cleanup transports #534

hexfusion commented Jan 22, 2021 •

edited

hexfusion commented Jan 25, 2021

openshift-ci-robot commented Feb 5, 2021

hexfusion commented Feb 5, 2021

openshift-ci-robot commented Feb 5, 2021

openshift-ci-robot commented Feb 5, 2021

openshift-ci-robot commented Feb 5, 2021

retroflexer commented Feb 5, 2021

openshift-ci-robot commented Feb 5, 2021

hexfusion commented Feb 5, 2021

hexfusion commented Feb 5, 2021

hexfusion commented Feb 5, 2021

hexfusion commented Feb 5, 2021

hexfusion commented Feb 5, 2021

hexfusion commented Feb 5, 2021

openshift-bot commented Feb 5, 2021

hexfusion commented Feb 5, 2021

hexfusion commented Feb 5, 2021

openshift-bot commented Feb 5, 2021

openshift-bot commented Feb 6, 2021

openshift-ci-robot commented Feb 6, 2021

hexfusion commented Feb 6, 2021

openshift-cherrypick-robot commented Feb 6, 2021

hexfusion commented Mar 3, 2021

openshift-cherrypick-robot commented Mar 3, 2021

hexfusion commented Mar 16, 2021

openshift-cherrypick-robot commented Mar 16, 2021

openshift-cherrypick-robot commented Mar 16, 2021

Bug 1925586: pkg/operator/metriccontroller: cleanup transports #534

Bug 1925586: pkg/operator/metriccontroller: cleanup transports #534

Conversation

hexfusion commented Jan 22, 2021 • edited

hexfusion commented Jan 25, 2021

openshift-ci-robot commented Feb 5, 2021

hexfusion commented Feb 5, 2021

openshift-ci-robot commented Feb 5, 2021

openshift-ci-robot commented Feb 5, 2021

openshift-ci-robot commented Feb 5, 2021

retroflexer commented Feb 5, 2021

openshift-ci-robot commented Feb 5, 2021

hexfusion commented Feb 5, 2021

hexfusion commented Feb 5, 2021

hexfusion commented Feb 5, 2021

hexfusion commented Feb 5, 2021

hexfusion commented Feb 5, 2021

hexfusion commented Feb 5, 2021

openshift-bot commented Feb 5, 2021

hexfusion commented Feb 5, 2021

hexfusion commented Feb 5, 2021

openshift-bot commented Feb 5, 2021

openshift-bot commented Feb 6, 2021

openshift-ci-robot commented Feb 6, 2021

hexfusion commented Feb 6, 2021

openshift-cherrypick-robot commented Feb 6, 2021

hexfusion commented Mar 3, 2021

openshift-cherrypick-robot commented Mar 3, 2021

hexfusion commented Mar 16, 2021

openshift-cherrypick-robot commented Mar 16, 2021

openshift-cherrypick-robot commented Mar 16, 2021

hexfusion commented Jan 22, 2021 •

edited