Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotate serving certs when duration less than minimum percent #606

Merged
merged 1 commit into from Jun 15, 2021
Merged

Rotate serving certs when duration less than minimum percent #606

merged 1 commit into from Jun 15, 2021

Conversation

marun
Copy link
Contributor

@marun marun commented May 28, 2021

This will ensure against expired serving certs breaking the cluster.

/cc @hexfusion

@openshift-ci openshift-ci bot requested a review from hexfusion May 28, 2021 00:40
lilic
lilic reviewed May 31, 2021
View reviewed changes
Copy link
Contributor

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion from my side.

pkg/operator/etcdcertsigner/etcdcertsignercontroller.go Outdated Show resolved Hide resolved
@marun
Rotate serving certs when duration less than minimum percent
09c1c9a 
This will ensure against expired serving certs breaking the cluster.
@hexfusion
Copy link
Contributor

/approve

temping to merge in 4.8, feelings @deads2k?
/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 1, 2021
@hexfusion
Copy link
Contributor

/hold cancel
/skip

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2021
@hexfusion
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, marun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marun
Copy link
Contributor Author

marun commented Jun 14, 2021

/retest

@marun
Copy link
Contributor Author

marun commented Jun 14, 2021

/retest

aws quota issues preventing successful cluster deployment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@wallylewis
Copy link

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2021 •
edited

@marun: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-disruptive 09c1c9a link /test e2e-gcp-disruptive
ci/prow/e2e-aws-disruptive 09c1c9a link /test e2e-aws-disruptive
ci/prow/e2e-gcp-disruptive-ovn 09c1c9a link /test e2e-gcp-disruptive-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hexfusion
Copy link
Contributor

/test e2e-agnostic

@openshift-merge-robot openshift-merge-robot merged commit bb708d6 into openshift:master Jun 15, 2021
This was referenced Jan 4, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilic lilic lilic left review comments

@hexfusion hexfusion Awaiting requested review from hexfusion

Assignees

@hexfusion hexfusion

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@marun @hexfusion @openshift-bot @wallylewis @lilic @openshift-merge-robot