Bug 1969633: pkg/operator/targetconfigcontroller: wait for kcm-o to generate certs before rollout #619
Conversation
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
hexfusion
force-pushed
the
wait-for-kcm
branch
4 times, most recently
from
eda0d26
to
0141219
Compare
hexfusion
changed the title
|
/test e2e-single-node-live-iso |
|
@romfreiman: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-metal-single-node-live-iso |
|
/test e2e-metal-single-node-live-iso |
… before rollout Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
|
/test e2e-metal-single-node-live-iso |
hexfusion
changed the title
openshift-ci
bot
added
bugzilla/severity-high
|
@hexfusion: This pull request references Bugzilla bug 1969633, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: sandeepknd. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hexfusion, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hexfusion: This pull request references Bugzilla bug 1969633, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: sandeepknd. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/prow/e2e-gcp-five-control-plane-replicas failure not related to this PR |
|
@hexfusion: Overrode contexts on behalf of hexfusion: ci/prow/e2e-gcp-five-control-plane-replicas In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@hexfusion: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1969633 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.8 |
|
@hexfusion: new pull request created: #621 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-managed-config configmap csr-controller-ca is a critical resource for the cluster and is generated by openshift-kube-apiserver-operator render command using ca minted on the installer. When KCM-O starts it deletes and replaces this resource and then manages cert rotation moving forward.
The PR fixes a race condition in SNO where if etcd and or kas rollout and generate disruption before the ca pivots manager we can brick the cluster if the operator loses leadership before the resource is generated. This can lead to node Not Ready and the operator not able to start again. Now we wait for the signal of pivot then continue rollout.
related to: openshift/cluster-kube-apiserver-operator#1169