Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject runbook url into alerts #628

Merged
merged 2 commits into from Jul 21, 2021

Conversation

lilic
Copy link
Contributor

@lilic lilic commented Jul 20, 2021

This is part of the alerting epic, which requires all critical alerts to have runbooks, this is done via the runbook_url field.

We can merge after openshift/runbooks#9 this PR is merged, as right now two runbooks don't exist yet.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2021
@openshift-ci openshift-ci bot requested review from ironcladlou and marun July 20, 2021 11:41
@lilic
Copy link
Contributor Author

lilic commented Jul 20, 2021

@hexfusion @marun please take a look, thanks!

jsonnet/main.jsonnet Outdated Show resolved Hide resolved
jsonnet/main.jsonnet Outdated Show resolved Hide resolved
jsonnet/main.jsonnet Outdated Show resolved Hide resolved
@lilic
Copy link
Contributor Author

lilic commented Jul 21, 2021

/hold cancel

@hexfusion please take a look, all runbooks now merged. 🎉

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2021
@hexfusion
Copy link
Contributor

/lgtm
/override ci/prow/e2e-gcp-five-control-plane-replicas

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2021

@hexfusion: Overrode contexts on behalf of hexfusion: ci/prow/e2e-gcp-five-control-plane-replicas

In response to this:

/lgtm
/override ci/prow/e2e-gcp-five-control-plane-replicas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, lilic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2021
@lilic
Copy link
Contributor Author

lilic commented Jul 21, 2021

/retest

auth failure...

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 96435e4 into openshift:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants