New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inject runbook url into alerts #628
Inject runbook url into alerts #628
Conversation
@hexfusion @marun please take a look, thanks! |
5c4a545
to
5adf369
Compare
/hold cancel @hexfusion please take a look, all runbooks now merged. 🎉 |
/lgtm |
@hexfusion: Overrode contexts on behalf of hexfusion: ci/prow/e2e-gcp-five-control-plane-replicas In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hexfusion, lilic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest auth failure... |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
This is part of the alerting epic, which requires all critical alerts to have runbooks, this is done via the runbook_url field.
We can merge after openshift/runbooks#9 this PR is merged, as right now two runbooks don't exist yet.
/hold