Bug 1986829: metrics: use client cert auth for metrics scraping

[stlaz]

The CMO is now capable of using client cert auth to scrape the metrics endpoints. Use that in our components to reduce API load and allow metrics collection when the API is down - given further authz conditions are met.

[openshift-ci]

@stlaz: This pull request references Bugzilla bug 1986829, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gangwgr

In response to this:

Bug 1986829: metrics: use client cert auth for metrics scraping

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lilic]

/lgtm

Thanks! Checked metrics are scrapped correctly, openshift_etcd_operator_build_info and etcd_debugging_raft_terms_total seems to be the only etcd operator metric we have?

/hold

[stlaz]

/retest
I am not quite sure about what metrics the etcd-operator exposes but as long as it's got the serviceMonitor configured, it's going to be generating a TokenReview request to the KAS every 2 minutes or so (I believe we added caching the response a few months back).

[openshift-ci]

@stlaz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-single-node	ffc04ef	link	/test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[marun]

@hexfusion 5 node failure is unrelated, maybe override the job?

[hexfusion]

/override ci/prow/e2e-gcp-five-control-plane-replicas

[openshift-ci]

@hexfusion: Overrode contexts on behalf of hexfusion: ci/prow/e2e-gcp-five-control-plane-replicas

In response to this:

/override ci/prow/e2e-gcp-five-control-plane-replicas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hexfusion]

/skip

[hexfusion]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, lilic, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hexfusion]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lilic]

/hold cancel

[openshift-ci]

@stlaz: Some pull requests linked via external trackers have merged:

• openshift/cluster-authentication-operator#469
• openshift/cluster-etcd-operator#634

The following pull requests linked via external trackers have not merged:

• openshift/cluster-kube-apiserver-operator#1190 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1986829 has not been moved to the MODIFIED state.

In response to this:

Bug 1986829: metrics: use client cert auth for metrics scraping

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.