Bug 1956879: pkg/operator/metriccontroller: read etcd-operator SA token rather than using prometheus #650

s-urbaniak · 2021-08-26T07:17:22Z

Currently, etcd-operator extracts the openshift-monitoring/prometheus-k8s service account token
to use it as a bearer token to execute requests against the prometheus API (via thanos).

Two issues were found:

The service account token extraction does not filter tokens annoted with
"kubernetes.io/created-by: openshift.io/create-dockercfg-secrets".

This causes randomly the wrong service account token to be picked up.

It impersonates requests against the prometheus API using the prometheus SA token
rather than using it owns.

This fixes it by reading the service account token directly from the pod file system.

/cc @lilic @hexfusion

…n using prometheus Currently, etcd-operator extracts the openshift-monitoring/prometheus-k8s service account token to use it as a bearer token to execute requests against the prometheus API (via thanos). Two issues were found: 1. The service account token extraction does not filter tokens annoted with "kubernetes.io/created-by: openshift.io/create-dockercfg-secrets". This causes randomly the wrong service account token to be picked up. 2. It impersonates requests against the prometheus API using the prometheus SA token rather than using it owns. This fixes it by reading the service account token directly from the pod file system.

openshift-ci · 2021-08-26T07:17:27Z

@s-urbaniak: This pull request references Bugzilla bug 1956879, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1956879: pkg/operator/metriccontroller: read etcd-operator SA token rather than using prometheus

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

s-urbaniak · 2021-08-26T07:33:20Z

/bugzilla refresh

openshift-ci · 2021-08-26T07:33:22Z

@s-urbaniak: This pull request references Bugzilla bug 1956879, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

s-urbaniak · 2021-08-26T07:34:05Z

/bugzilla refresh

openshift-ci · 2021-08-26T07:34:13Z

@s-urbaniak: This pull request references Bugzilla bug 1956879, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @geliu2016

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stlaz · 2021-08-26T07:46:52Z

/lgtm

lilic

/lgtm
/approve
Thanks!

/hold
for Sam to have a look.

lilic · 2021-08-26T08:58:14Z

ci/prow/e2e-gcp-five-control-plane-replicas — Job failed.

is a known failure

lilic · 2021-08-26T11:45:01Z

/retest

hexfusion · 2021-08-26T13:32:04Z

/approve

hexfusion · 2021-08-26T13:33:45Z

/override ci/prow/e2e-gcp-five-control-plane-replicas

/retest
/hold cancel

openshift-ci · 2021-08-26T13:39:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, lilic, s-urbaniak, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [hexfusion]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2021-08-26T13:53:40Z

@hexfusion: Overrode contexts on behalf of hexfusion: ci/prow/e2e-gcp-five-control-plane-replicas

In response to this:

/override ci/prow/e2e-gcp-five-control-plane-replicas

/retest
/hold cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hexfusion · 2021-08-26T14:09:40Z

/retest

hexfusion · 2021-08-26T16:42:34Z

/refresh
/retest
/hold cancel

openshift-ci-robot · 2021-08-26T16:42:43Z

@s-urbaniak: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-agnostic-upgrade	`02ba5d5`	link	`/test e2e-agnostic-upgrade`
ci/prow/e2e-gcp-five-control-plane-replicas	`02ba5d5`	link	`/test e2e-gcp-five-control-plane-replicas`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-08-26T21:15:27Z

/retest-required