Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindata/bootkube/bootstrap-manifests: add etcdctl container to bootstrap-etcd #678

Merged
merged 1 commit into from Sep 30, 2021
Merged

bindata/bootkube/bootstrap-manifests: add etcdctl container to bootstrap-etcd #678

merged 1 commit into from Sep 30, 2021

Conversation

hexfusion
Copy link
Contributor

This PR adds the etcdctl container to the bootstrap node etcd pod adding to the debugability of bootstrap failures.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2021
@hexfusion
Copy link
Contributor Author

cc @hasbro17

@hexfusion hexfusion force-pushed the add-etcdctl-bootstrap branch 2 times, most recently from 3ca9c43 to a4b43a6 Compare September 29, 2021 20:48
hasbro17
hasbro17 approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2021
@hexfusion
Copy link
Contributor Author

sorry had one more cleanup on mounts

@hasbro17
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@hexfusion
Copy link
Contributor Author

hexfusion commented Sep 29, 2021 •
edited

cluster-etcd-operator/bindata/bootkube/bootstrap-manifests/etcd-member-pod.yaml

Lines 72 to 74 in 3b7350c

- name: conf
mountPath: /etc/etcd/

sigh, missed one more..

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@hexfusion
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2021
@hexfusion
bindata/bootkube/bootstrap-manifests: add etcdctl container to bootst…
9e3ffd1 
…rap-etcd

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2021
@hasbro17
Copy link
Contributor

/lgtm

Third time's the charm.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasbro17, hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2021 •
edited

@hexfusion: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node 9e3ffd1 link false /test e2e-aws-single-node
ci/prow/e2e-gcp-five-control-plane-replicas 9e3ffd1 link false /test e2e-gcp-five-control-plane-replicas

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hexfusion
Copy link
Contributor Author

unrelated

/retest-required

@hexfusion
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 17978bc into openshift:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasbro17 hasbro17 hasbro17 approved these changes

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@marun marun Awaiting requested review from marun

Assignees

@hasbro17 hasbro17

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hexfusion @hasbro17 @openshift-bot @openshift-merge-robot