Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2053582: Track static pod lifecycle #750

Merged
merged 2 commits into from Feb 15, 2022
Merged

Bug 2053582: Track static pod lifecycle #750

merged 2 commits into from Feb 15, 2022

Conversation

p0lyn0mial
Copy link
Contributor

No description provided.

@p0lyn0mial p0lyn0mial force-pushed the proof-1320 branch 2 times, most recently from 8f25504 to efabf6e Compare February 15, 2022 10:07
@p0lyn0mial p0lyn0mial changed the title proof https://github.com/openshift/library-go/pull/1320 Bug 2053582: Track static pod lifecycle Feb 15, 2022
@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Feb 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2022

@p0lyn0mial: This pull request references Bugzilla bug 2053582, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

Bug 2053582: Track static pod lifecycle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 15, 2022
@openshift-ci openshift-ci bot requested a review from wangke19 February 15, 2022 12:59
@p0lyn0mial
Copy link
Contributor Author

/assign @dgrisonnet @tkashem

@dusk125
Copy link
Contributor

dusk125 commented Feb 15, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2022
@deads2k deads2k added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2022
@tkashem
Copy link
Contributor

tkashem commented Feb 15, 2022

/lgtm
/retest

@p0lyn0mial
Copy link
Contributor Author

I had to rebase, #748 merged first, PTAL

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2022
@tkashem
Copy link
Contributor

tkashem commented Feb 15, 2022

/lgtm

@tkashem
Copy link
Contributor

tkashem commented Feb 15, 2022

cc @dusk125

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: dusk125, p0lyn0mial, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2022

@p0lyn0mial: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-five-control-plane-replicas f46b30d link false /test e2e-gcp-five-control-plane-replicas

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5e3bf2a into openshift:master Feb 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2022

@p0lyn0mial: Bugzilla bug 2053582 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

Bug 2053582: Track static pod lifecycle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dusk125 dusk125 Awaiting requested review from dusk125

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@wangke19 wangke19 Awaiting requested review from wangke19

Assignees

@dusk125 dusk125

@tkashem tkashem

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@p0lyn0mial @dusk125 @tkashem @deads2k @dgrisonnet @openshift-merge-robot