[release-4.9] OCPBUGS-2120: fix cert rotation on IP changes

[openshift-cherrypick-robot]

This is an automated cherry-pick of #936

/assign tjungblu

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-1758 has been cloned as Jira Issue OCPBUGS-2120. Retitling PR to link against new bug.
/retitle [release-4.9] OCPBUGS-2120: fix cert rotation on IP changes

In response to this:

This is an automated cherry-pick of #936

/assign tjungblu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.9] OCPBUGS-2120: fix cert rotation on IP changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-2120, which is invalid:

• expected dependent Jira Issue OCPBUGS-1758 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #936

/assign tjungblu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-five-control-plane-replicas	e9ce6e6	link	false	/test e2e-gcp-five-control-plane-replicas

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[tjungblu]

/cherry-pick release-4.8

[openshift-cherrypick-robot]

@tjungblu: once the present PR merges, I will cherry-pick it on top of release-4.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Elbehery]

/lgtm

[EmilyM1]

/lgtm

[EmilyM1]

/lgtm

[hasbro17]

/label backport-risk-assessed,
/approve

[openshift-ci]

@hasbro17: The label(s) /label backport-risk-assessed, cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label backport-risk-assessed,
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hasbro17]

/label backport-risk-assessed

[tjungblu]

/jira refresh

[openshift-ci-robot]

@tjungblu: An error was encountered querying GitHub for users with public email (geliu@redhat.com) for bug OCPBUGS-2120 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.

Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: connect: connection refused

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tjungblu]

/jira refresh

[openshift-ci-robot]

@tjungblu: This pull request references Jira Issue OCPBUGS-2120, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.9.z) matches configured target version for branch (4.9.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-1758 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
• dependent Jira Issue OCPBUGS-1758 targets the "4.10.z" version, which is one of the valid target versions: 4.10.0, 4.10.z
• bug has dependents

Requesting review from QA contact:
/cc @geliu2016

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[geliu2016]

/label cherry-pick-approved

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, EmilyM1, geliu2016, hasbro17, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hasbro17]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

• openshift/cluster-etcd-operator#945

Jira Issue OCPBUGS-2120 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #936

/assign tjungblu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@tjungblu: #945 failed to apply on top of branch "release-4.8":

Applying: Bug 2046335: fix cert rotation on IP changes
Using index info to reconstruct a base tree...
M	pkg/operator/etcdcertsigner/etcdcertsignercontroller.go
M	pkg/operator/etcdcertsigner/etcdcertsignercontroller_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/operator/etcdcertsigner/etcdcertsignercontroller_test.go
CONFLICT (content): Merge conflict in pkg/operator/etcdcertsigner/etcdcertsignercontroller_test.go
Auto-merging pkg/operator/etcdcertsigner/etcdcertsignercontroller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bug 2046335: fix cert rotation on IP changes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.