OCPBUGS-29637: azurepathfix: fix stack hub, government and workload identity setup #1003
Conversation
openshift-ci
bot
added
the
approved
this fixes azure government cloud, where the suffix is different.
flavianmissi
force-pushed
the
OCPBUGS-29638
branch
from
f55744c
to
9b618e7
Compare
flavianmissi
changed the title
openshift-ci-robot
added
jira/severity-critical
|
@flavianmissi: This pull request references Jira Issue OCPBUGS-29638, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@flavianmissi: This pull request references Jira Issue OCPBUGS-29638, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
this is critical to both 4.15 and another backport to 4.14. |
|
@flavianmissi: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
flavianmissi
changed the title
|
@flavianmissi: This pull request references Jira Issue OCPBUGS-29637, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
this should fix the job for clusters with workload identity
flavianmissi
force-pushed
the
OCPBUGS-29638
branch
from
2ce75ce
to
ff111b7
Compare
|
/jira refresh |
|
@wewang58: This pull request references Jira Issue OCPBUGS-29637, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
flavianmissi
force-pushed
the
OCPBUGS-29638
branch
from
342be8f
to
7684f4f
Compare
flavianmissi
changed the title
|
@flavianmissi: An error was encountered querying GitHub for users with public email (wewang@redhat.com) for bug OCPBUGS-29637 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details. Full error message.
Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: connect: connection refused
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/hold
the storage controller sometimes recreates the storage account after the job has been created. to account for that, we compare the container envs between created and desired values, and when they differ we recreate the job.
|
/test verify |
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.16-e2e-azure-ovn 4 |
|
@flavianmissi: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/16427340-cfe8-11ee-83dc-c951619146e3-0 |
|
/test e2e-azure-operator |
|
The payload job failed not because the tests didn't pass, but because I chose to run it 4 times (instead of the required 6 to succeed). I inspected every test with |
|
I'm running the same tests locally, let's see who's fastest. |
|
Test run on a I'm trying to get a 4.16 build of this PR but so far have not been able to. Will report back. |
| if err != nil { | ||
| return nil, false, err | ||
| } | ||
| expectedJob := exp.(*batchv1.Job) |
There was a problem hiding this comment.
nit: is it better to check the conversion with expectedJob, ok to ignore the ones that is !ok
| GracePeriodSeconds: &gracePeriod, | ||
| PropagationPolicy: &propagationPolicy, | ||
| } | ||
| if err := gapfj.Delete(opts); err != nil { |
There was a problem hiding this comment.
Nit: Is it possible that err can be NotFound which is valid for deletes to continue gapfj.Create
|
It is already on hold; |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, dmage, flavianmissi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
the job changed in this PR does not run on AWS, and hypershift is AWS only - the failures are unrelated. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@flavianmissi: Overrode contexts on behalf of flavianmissi: ci/prow/e2e-hypershift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@flavianmissi: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@flavianmissi: Jira Issue OCPBUGS-29637: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-29637 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@flavianmissi: new pull request created: #1004 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-image-registry-operator-container-v4.16.0-202402210939.p0.g41ea2a9.assembly.stream.el9 for distgit ose-cluster-image-registry-operator. |
No description provided.