Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-29755: azurepathfix: fix stack hub, government and workload identity setup #1005

Merged
merged 7 commits into from Feb 21, 2024
Merged

[release-4.14] OCPBUGS-29755: azurepathfix: fix stack hub, government and workload identity setup #1005

merged 7 commits into from Feb 21, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1004

/assign flavianmissi

@flavianmissi
cmd/move-blobs: use endpoint suffix from environment
ade4f32 
this fixes azure government cloud, where the suffix is different.
@flavianmissi
azurepathfixjob: make account key secret optional
0c555f7 
this should fix the job for clusters with workload identity
@flavianmissi
azurepathfix: create Azure Stack Hub environment file accordingly
ec4e37b
@flavianmissi
azurepathfixjob: mount service account volume for token
fb6c7a7 
without this, workload identity will not work for the job pod.
@flavianmissi
azurepathfix: skip job creation on Azure Stack Hub
ac9b6e1 
ASH does not support the api version used by the sdk version in
move-blobs, so we skip running it there.

also consistently use the client options on every instantiation.
@flavianmissi
azurepathfixjob: recreate job when detect changes to container env vars
353a0cb 
the storage controller sometimes recreates the storage account after the
job has been created. to account for that, we compare the container envs
between created and desired values, and when they differ we recreate the
job.
@flavianmissi
azurepathfixjob: set backoff limit to 6 (the default)
e8cc9bd
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 21, 2024
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-29638 has been cloned as Jira Issue OCPBUGS-29755. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-29755: azurepathfix: fix stack hub, government and workload identity setup

In response to this:

This is an automated cherry-pick of #1004

/assign flavianmissi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-29638: azurepathfix: fix stack hub, government and workload identity setup [release-4.14] OCPBUGS-29755: azurepathfix: fix stack hub, government and workload identity setup Feb 21, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 21, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-29755, which is invalid:

  • expected dependent Jira Issue OCPBUGS-29638 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1004

/assign flavianmissi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@flavianmissi
Copy link
Member

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 21, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2024
@flavianmissi
Copy link
Member

e2e-hypershift show the same failure we see here in periodic tests, see https://sippy.dptools.openshift.org/sippy-ng/jobs/4.14/runs?filters=%7B%22items%22%3A%5B%7B%22columnField%22%3A%22name%22%2C%22operatorValue%22%3A%22equals%22%2C%22value%22%3A%22periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn%22%7D%5D%7D&sortField=timestamp&sort=desc.
we are safe to override them.

/override ci/prow/e2e-hypershift

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

@flavianmissi: Overrode contexts on behalf of flavianmissi: ci/prow/e2e-hypershift

In response to this:

e2e-hypershift show the same failure we see here in periodic tests, see https://sippy.dptools.openshift.org/sippy-ng/jobs/4.14/runs?filters=%7B%22items%22%3A%5B%7B%22columnField%22%3A%22name%22%2C%22operatorValue%22%3A%22equals%22%2C%22value%22%3A%22periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn%22%7D%5D%7D&sortField=timestamp&sort=desc.
we are safe to override them.

/override ci/prow/e2e-hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flavianmissi
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 21, 2024
@openshift-ci-robot
Copy link
Contributor

@flavianmissi: This pull request references Jira Issue OCPBUGS-29755, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-29638 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-29638 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @xiuwang

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from xiuwang February 21, 2024 14:16
@wewang58
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 21, 2024
@wewang58
Copy link

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@wewang58: This pull request references Jira Issue OCPBUGS-29755, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-29638 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-29638 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @wewang58

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from wewang58 February 21, 2024 15:09
@flavianmissi
Copy link
Member

e2e-azure-operator failure is due to a known flake.

@wewang58
Copy link

Installed different profiles clusters successfully and upgrade from 4.13.33 to the custom build successfully, pull image successfully

oc get pods -n wewang

NAME READY STATUS RESTARTS AGE
new-default-deploy1-548c9d9fc7-47xkq 1/1 Running 0 53m

podman pull --tls-verify=false ${REGISTRY}/wewang/hello:latest

Trying to pull default-route-openshift-image-registry.apps.wewang-413b.qemag.azure.devcluster.openshift.com/wewang/hello:latest...
Getting image source signatures
Copying blob b8c72134a16a [======================>---------------] 18.2MiB / 30.2MiB | 22.4 KiB/s
Copying blob b8c72134a16a [======================>---------------] 18.4MiB / 30.2MiB | 32.9 KiB/s
Copying blob b8c72134a16a done |
Copying config fc87538605 done |
Writing manifest to image destination
fc875386057e8d1f478f11b00cfdad723ec49845b4aacd8c4b2588aba4ef715f

oc get clusterversion

NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.14.0-0.test-2024-02-21-131627-ci-ln-n0hpy3k-latest True False 51m Cluster version is 4.14.0-0.test-2024-02-21-131627-ci-ln-n0hpy3k-latest

@wewang58
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 21, 2024
@openshift-ci-robot openshift-ci-robot removed the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 21, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-29755, which is invalid:

  • expected dependent Jira Issue OCPBUGS-29638 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is an automated cherry-pick of #1004

/assign flavianmissi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 21, 2024
@flavianmissi
Copy link
Member

e2e-aws-operator failures are unrelated to the changes in this PR (flakes).
This code doesn't run on AWS. It does not change the way the operator handles RELEASE_VERSION (TestVersionReporting). The other failure (TestImageRegistryRemovedWithImages) is well known: https://issues.redhat.com/browse/IR-315

/override ci/prow/e2e-aws-operator

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@flavianmissi: This pull request references Jira Issue OCPBUGS-29755, which is invalid:

  • expected dependent Jira Issue OCPBUGS-29638 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

e2e-aws-operator failures are unrelated to the changes in this PR (flakes).
This code doesn't run on AWS. It does not change the way the operator handles RELEASE_VERSION (TestVersionReporting). The other failure (TestImageRegistryRemovedWithImages) is well known: https://issues.redhat.com/browse/IR-315

/override ci/prow/e2e-aws-operator

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@flavianmissi
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 21, 2024
@openshift-ci-robot
Copy link
Contributor

@flavianmissi: This pull request references Jira Issue OCPBUGS-29755, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-29638 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-29638 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @wewang58

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

@flavianmissi: Overrode contexts on behalf of flavianmissi: ci/prow/e2e-aws-operator

In response to this:

e2e-aws-operator failures are unrelated to the changes in this PR (flakes).
This code doesn't run on AWS. It does not change the way the operator handles RELEASE_VERSION (TestVersionReporting). The other failure (TestImageRegistryRemovedWithImages) is well known: https://issues.redhat.com/browse/IR-315

/override ci/prow/e2e-aws-operator

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

@flavianmissi: Overrode contexts on behalf of flavianmissi: ci/prow/e2e-aws-operator

In response to this:

/override ci/prow/e2e-aws-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift e8cc9bd link true /test e2e-hypershift
ci/prow/e2e-aws-operator e8cc9bd link true /test e2e-aws-operator
ci/prow/e2e-azure-operator e8cc9bd link false /test e2e-azure-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 791c39c into openshift:release-4.14 Feb 21, 2024
11 of 12 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-29755: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29755 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #1004

/assign flavianmissi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-image-registry-operator-container-v4.14.0-202402211738.p0.g791c39c.assembly.stream.el8 for distgit ose-cluster-image-registry-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2024-02-21-181159

@PratikMahajan PratikMahajan mentioned this pull request Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmage dmage Awaiting requested review from dmage

@flavianmissi flavianmissi Awaiting requested review from flavianmissi

@xiuwang xiuwang Awaiting requested review from xiuwang

@wewang58 wewang58 Awaiting requested review from wewang58

Assignees

@flavianmissi flavianmissi

@xiuwang xiuwang

@wewang58 wewang58

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @flavianmissi @wewang58 @openshift-bot @openshift-merge-robot @xiuwang