Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: bump golangci-lint to v1.56.2 #1013

Merged
merged 2 commits into from Mar 14, 2024

Conversation

flavianmissi
Copy link
Member

also run gofumpt.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 13, 2024
@openshift-ci-robot
Copy link
Contributor

@flavianmissi: This pull request explicitly references no jira issue.

In response to this:

also run gofumpt.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2024
@dmage
Copy link
Member

dmage commented Mar 13, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2024
@flavianmissi
Copy link
Member Author

/retest

@flavianmissi
Copy link
Member Author

this does not affect end-users
/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Mar 13, 2024
@flavianmissi
Copy link
Member Author

flavianmissi commented Mar 13, 2024

@wewang58 this does not affect the product in any way, it's just bumping a linter version. can you qe approve?
/assign @wewang58

@flavianmissi
Copy link
Member Author

/test e2e-azure-operator

@wewang58
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 14, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 749d902 into openshift:master Mar 14, 2024
11 of 12 checks passed
@flavianmissi flavianmissi deleted the fix-golangci-lint branch March 14, 2024 13:42
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-image-registry-operator-container-v4.16.0-202403141746.p0.g749d902.assembly.stream.el9 for distgit ose-cluster-image-registry-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants