Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-30484: bump indirect google protobuf dependency #1015

Merged
merged 2 commits into from Apr 15, 2024

Conversation

flavianmissi
Copy link
Member

The google api related packages depend on google.golang.org/protobuf/encoding/protojson, so to bump it we bump the google api packages.


Unrelatedly the otel module had some breaking change which required me to manually go get a couple packages. This was the error:

go: downloading google.golang.org/api v0.172.0
go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20240318140521-94a12d6c2237
go: finding module for package go.opentelemetry.io/otel/exporters/otlp/internal/envconfig
go: finding module for package go.opentelemetry.io/otel/exporters/otlp/internal
go: github.com/openshift/cluster-image-registry-operator/cmd/cluster-image-registry-operator imports
	github.com/openshift/library-go/pkg/controller/controllercmd imports
	github.com/openshift/library-go/pkg/config/serving imports
	k8s.io/apiserver/pkg/server/options imports
	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc imports
	go.opentelemetry.io/otel/exporters/otlp/internal: module go.opentelemetry.io/otel/exporters/otlp@latest found (v0.20.1), but does not contain package go.opentelemetry.io/otel/exporters/otlp/internal
go: github.com/openshift/cluster-image-registry-operator/cmd/cluster-image-registry-operator imports
	github.com/openshift/library-go/pkg/controller/controllercmd imports
	github.com/openshift/library-go/pkg/config/serving imports
	k8s.io/apiserver/pkg/server/options imports
	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc imports
	go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/otlpconfig imports
	go.opentelemetry.io/otel/exporters/otlp/internal/envconfig: module go.opentelemetry.io/otel/exporters/otlp@latest found (v0.20.1), but does not contain package go.opentelemetry.io/otel/exporters/otlp/internal/envconfig

and the fix:

go get go.opentelemetry.io/otel/exporters/otlp/otlptrace@v1.19.0
go get go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc@v1.19.0

also bump a few other unrelated packages to fix an otel issue during `go
mod vendor`
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 3, 2024
@openshift-ci-robot
Copy link
Contributor

@flavianmissi: This pull request references Jira Issue OCPBUGS-30484, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xiuwang

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The google api related packages depend on google.golang.org/protobuf/encoding/protojson, so to bump it we bump the google api packages.


Unrelatedly the otel module had some breaking change which required me to manually go get a couple packages. This was the error:

go: downloading google.golang.org/api v0.172.0
go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20240318140521-94a12d6c2237
go: finding module for package go.opentelemetry.io/otel/exporters/otlp/internal/envconfig
go: finding module for package go.opentelemetry.io/otel/exporters/otlp/internal
go: github.com/openshift/cluster-image-registry-operator/cmd/cluster-image-registry-operator imports
  github.com/openshift/library-go/pkg/controller/controllercmd imports
  github.com/openshift/library-go/pkg/config/serving imports
  k8s.io/apiserver/pkg/server/options imports
  go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc imports
  go.opentelemetry.io/otel/exporters/otlp/internal: module go.opentelemetry.io/otel/exporters/otlp@latest found (v0.20.1), but does not contain package go.opentelemetry.io/otel/exporters/otlp/internal
go: github.com/openshift/cluster-image-registry-operator/cmd/cluster-image-registry-operator imports
  github.com/openshift/library-go/pkg/controller/controllercmd imports
  github.com/openshift/library-go/pkg/config/serving imports
  k8s.io/apiserver/pkg/server/options imports
  go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc imports
  go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/otlpconfig imports
  go.opentelemetry.io/otel/exporters/otlp/internal/envconfig: module go.opentelemetry.io/otel/exporters/otlp@latest found (v0.20.1), but does not contain package go.opentelemetry.io/otel/exporters/otlp/internal/envconfig

and the fix:

go get go.opentelemetry.io/otel/exporters/otlp/otlptrace@v1.19.0
go get go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc@v1.19.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from xiuwang April 3, 2024 13:07
@openshift-ci openshift-ci bot requested review from adambkaplan and dmage April 3, 2024 13:09
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
@flavianmissi
Copy link
Member Author

/retest

@dmage
Copy link
Member

dmage commented Apr 9, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2024
Copy link
Contributor

openshift-ci bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a308c62 and 2 for PR HEAD a2dd98b in total

@xiuwang
Copy link

xiuwang commented Apr 10, 2024

/retest

@xiuwang
Copy link

xiuwang commented Apr 10, 2024

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 10, 2024
@openshift-ci-robot
Copy link
Contributor

@flavianmissi: This pull request references Jira Issue OCPBUGS-30484, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xiuwang

In response to this:

The google api related packages depend on google.golang.org/protobuf/encoding/protojson, so to bump it we bump the google api packages.


Unrelatedly the otel module had some breaking change which required me to manually go get a couple packages. This was the error:

go: downloading google.golang.org/api v0.172.0
go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20240318140521-94a12d6c2237
go: finding module for package go.opentelemetry.io/otel/exporters/otlp/internal/envconfig
go: finding module for package go.opentelemetry.io/otel/exporters/otlp/internal
go: github.com/openshift/cluster-image-registry-operator/cmd/cluster-image-registry-operator imports
  github.com/openshift/library-go/pkg/controller/controllercmd imports
  github.com/openshift/library-go/pkg/config/serving imports
  k8s.io/apiserver/pkg/server/options imports
  go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc imports
  go.opentelemetry.io/otel/exporters/otlp/internal: module go.opentelemetry.io/otel/exporters/otlp@latest found (v0.20.1), but does not contain package go.opentelemetry.io/otel/exporters/otlp/internal
go: github.com/openshift/cluster-image-registry-operator/cmd/cluster-image-registry-operator imports
  github.com/openshift/library-go/pkg/controller/controllercmd imports
  github.com/openshift/library-go/pkg/config/serving imports
  k8s.io/apiserver/pkg/server/options imports
  go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc imports
  go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/otlpconfig imports
  go.opentelemetry.io/otel/exporters/otlp/internal/envconfig: module go.opentelemetry.io/otel/exporters/otlp@latest found (v0.20.1), but does not contain package go.opentelemetry.io/otel/exporters/otlp/internal/envconfig

and the fix:

go get go.opentelemetry.io/otel/exporters/otlp/otlptrace@v1.19.0
go get go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc@v1.19.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xiuwang
Copy link

xiuwang commented Apr 10, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 10, 2024
@flavianmissi
Copy link
Member Author

I've seen these tests failing on other PRs too, let's retest once more to see if anything changed.
/retest

@flavianmissi
Copy link
Member Author

Poked around for info and it looks like hypershift CI is down. Let's give them a few days to fix it before retesting.

@flavianmissi
Copy link
Member Author

/retest

Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

@flavianmissi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d87f0c7 into openshift:master Apr 15, 2024
12 checks passed
@openshift-ci-robot
Copy link
Contributor

@flavianmissi: Jira Issue OCPBUGS-30484: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30484 has been moved to the MODIFIED state.

In response to this:

The google api related packages depend on google.golang.org/protobuf/encoding/protojson, so to bump it we bump the google api packages.


Unrelatedly the otel module had some breaking change which required me to manually go get a couple packages. This was the error:

go: downloading google.golang.org/api v0.172.0
go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20240318140521-94a12d6c2237
go: finding module for package go.opentelemetry.io/otel/exporters/otlp/internal/envconfig
go: finding module for package go.opentelemetry.io/otel/exporters/otlp/internal
go: github.com/openshift/cluster-image-registry-operator/cmd/cluster-image-registry-operator imports
  github.com/openshift/library-go/pkg/controller/controllercmd imports
  github.com/openshift/library-go/pkg/config/serving imports
  k8s.io/apiserver/pkg/server/options imports
  go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc imports
  go.opentelemetry.io/otel/exporters/otlp/internal: module go.opentelemetry.io/otel/exporters/otlp@latest found (v0.20.1), but does not contain package go.opentelemetry.io/otel/exporters/otlp/internal
go: github.com/openshift/cluster-image-registry-operator/cmd/cluster-image-registry-operator imports
  github.com/openshift/library-go/pkg/controller/controllercmd imports
  github.com/openshift/library-go/pkg/config/serving imports
  k8s.io/apiserver/pkg/server/options imports
  go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc imports
  go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/otlpconfig imports
  go.opentelemetry.io/otel/exporters/otlp/internal/envconfig: module go.opentelemetry.io/otel/exporters/otlp@latest found (v0.20.1), but does not contain package go.opentelemetry.io/otel/exporters/otlp/internal/envconfig

and the fix:

go get go.opentelemetry.io/otel/exporters/otlp/otlptrace@v1.19.0
go get go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc@v1.19.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-image-registry-operator-container-v4.16.0-202404151450.p0.gd87f0c7.assembly.stream.el9 for distgit ose-cluster-image-registry-operator.
All builds following this will include this PR.

@flavianmissi flavianmissi deleted the OCPBUGS-30484 branch April 16, 2024 06:45
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-04-16-015315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants