Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: remove bparees from owners #1019

Merged
merged 1 commit into from Apr 8, 2024

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Apr 8, 2024

no longer makes sense for me to have approval rights here (probably hasn't for a while).

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 8, 2024
@openshift-ci-robot
Copy link
Contributor

@bparees: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bparees
Copy link
Contributor Author

bparees commented Apr 8, 2024

/assign @dmage

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2024
@flavianmissi
Copy link
Member

/lgtm
thanks for all your work on the image registry and image streams Ben!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2024
Copy link
Contributor

openshift-ci bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bparees,flavianmissi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flavianmissi
Copy link
Member

this is a simple OWNERS change
/override e2e-hypershift
/label docs-approved
/label px-approved
/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Apr 8, 2024
Copy link
Contributor

openshift-ci bot commented Apr 8, 2024

@flavianmissi: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-hypershift

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-hypershift
  • ci/prow/e2e-hypershift-conformance
  • pull-ci-openshift-cluster-image-registry-operator-master-e2e-hypershift
  • pull-ci-openshift-cluster-image-registry-operator-master-e2e-hypershift-conformance
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

this is a simple OWNERS change
/override e2e-hypershift
/label docs-approved
/label px-approved
/label qe-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5361c58 and 2 for PR HEAD 7fd718e in total

@bparees
Copy link
Contributor Author

bparees commented Apr 8, 2024

/override ci/prow/e2e-hypershift

Copy link
Contributor

openshift-ci bot commented Apr 8, 2024

@bparees: Overrode contexts on behalf of bparees: ci/prow/e2e-hypershift

In response to this:

/override ci/prow/e2e-hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit a308c62 into openshift:master Apr 8, 2024
3 checks passed
Copy link
Contributor

openshift-ci bot commented Apr 8, 2024

@bparees: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-image-registry-operator-container-v4.16.0-202404090113.p0.ga308c62.assembly.stream.el9 for distgit ose-cluster-image-registry-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants