Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create secret before deployment #170

Merged
merged 3 commits into from
Jan 29, 2019
Merged

Create secret before deployment #170

merged 3 commits into from
Jan 29, 2019

Conversation

dmage
Copy link
Member

@dmage dmage commented Jan 24, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 24, 2019
@dmage dmage mentioned this pull request Jan 24, 2019
Closed
@dmage
Copy link
Member Author

dmage commented Jan 24, 2019 

level=warning msg="RetryWatcher - getting event failed! Re-creating the watcher. Last RV: 271"
level=fatal msg="waiting for bootstrap-complete: timed out waiting for the condition"

/retest

@bparees
Copy link
Contributor

bparees commented Jan 24, 2019

/assign @coreydaley

legionus
legionus approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@legionus legionus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, legionus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@legionus
Copy link
Contributor

/retest

1 similar comment
@legionus
Copy link
Contributor

/retest

@coreydaley
Copy link
Member

@legionus a retest isn't going to help, if you look at the test logs there is a nill pointer dereference in what looks to be /go/src/github.com/openshift/cluster-image-registry-operator/pkg/resource/secret.go:57 (or somewhere thereabouts.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2019
@dmage
Copy link
Member Author

dmage commented Jan 25, 2019

NewDriver didn't return an error when it had a problem. Fixed.

@dmage
Copy link
Member Author

dmage commented Jan 25, 2019

level=fatal msg="waiting for openshift-console URL: context deadline exceeded"
/retest

@legionus
Copy link
Contributor

/retest

3 similar comments
@dmage
Copy link
Member Author

dmage commented Jan 26, 2019

/retest

@dmage
Copy link
Member Author

dmage commented Jan 28, 2019

/retest

@legionus
Copy link
Contributor

/retest

@legionus legionus added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2019
@legionus
Copy link
Contributor

/retest

1 similar comment
@dmage
Copy link
Member Author

dmage commented Jan 28, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bparees
Copy link
Contributor

bparees commented Jan 28, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 7e196ad into openshift:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legionus legionus legionus approved these changes

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@legionus legionus

@coreydaley coreydaley

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dmage @bparees @openshift-ci-robot @legionus @coreydaley @openshift-bot @openshift-merge-robot