remove unnecessary status.internalregistryhostname field #184
Conversation
openshift-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
bparees
force-pushed
the
imageconfigstatus
branch
from
2a4291b
to
61a1bf7
Compare
|
/retest |
1 similar comment
|
/retest |
|
/refresh |
|
Looks good, but it's a bit suspicious that pkg/resource/nodecadaemon.go has two-space indentation. I've never seen it from gofmt. |
bparees
force-pushed
the
imageconfigstatus
branch
from
61a1bf7
to
0f0dd4a
Compare
yeah not sure what's going on, sublime is formatting it that way for some reason...I just manually ran gofmt and repushed so it should be good now. |
|
and apparently we're not running a make verify job on our PRs :( |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
1 similar comment
|
/retest |
After further consideration i think setting the internal registry hostname in the registry resource status was unnecessary, and not doing it simplifies the code and makes the generator more like the other generators.
As part of this PR I also fixed up the node-ca daemon to actually use the internalregistryhostname value, which it previously was not doing, and switched it to fetch the value from the image config resource instead of the registry resource.