Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate jUnit XML reports #193

Merged
merged 1 commit into from
Feb 9, 2019
Merged

Generate jUnit XML reports #193

merged 1 commit into from
Feb 9, 2019

Conversation

dmage
Copy link
Member

@dmage dmage commented Feb 6, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 6, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2019
@bparees
Copy link
Contributor

bparees commented Feb 6, 2019

lgtm assuming your testing gives the desired output

@dmage dmage force-pushed the test-go branch 6 times, most recently from 98b7a13 to 251dc46 Compare February 7, 2019 16:35
@dmage
Copy link
Member Author

dmage commented Feb 7, 2019

Examples of failures: unit, e2e.

/assign @legionus @bparees @coreydaley

bparees
bparees reviewed Feb 7, 2019
View reviewed changes
Makefile
test-unit:
go test ./cmd/... ./pkg/...
test-unit: verify
./hack/test-go.sh ./cmd/... ./pkg/...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we be consistent and set GOCACHE=off here too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOCACHE=off is needed for tests that use external services. Our unit tests don't use network, so it's ok to cache them.

legionus
legionus approved these changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@legionus legionus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparees
Copy link
Contributor

bparees commented Feb 7, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, dmage, legionus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bparees,dmage,legionus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dmage
Copy link
Member Author

dmage commented Feb 8, 2019

/retest

3 similar comments
@dmage
Copy link
Member Author

dmage commented Feb 8, 2019

/retest

@dmage
Copy link
Member Author

dmage commented Feb 8, 2019

/retest

@dmage
Copy link
Member Author

dmage commented Feb 8, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 48e2684 into openshift:master Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees bparees left review comments

@legionus legionus legionus approved these changes

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@legionus legionus

@bparees bparees

@coreydaley coreydaley

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dmage @bparees @openshift-ci-robot @openshift-bot @legionus @coreydaley @openshift-merge-robot