Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use generator for ClusterOperator #253

Merged
merged 4 commits into from Apr 24, 2019
Merged

Use generator for ClusterOperator #253

merged 4 commits into from Apr 24, 2019

Conversation

legionus
Copy link
Contributor

Fixes #250

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2019
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 11, 2019
@legionus
Copy link
Contributor Author

/retest

@legionus legionus changed the title [WIP] Use generator for ClusterOperator Use generator for ClusterOperator Apr 12, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2019
@legionus
Copy link
Contributor Author

/retest

10 similar comments
@legionus
Copy link
Contributor Author

/retest

@legionus
Copy link
Contributor Author

/retest

@legionus
Copy link
Contributor Author

/retest

@legionus
Copy link
Contributor Author

/retest

@legionus
Copy link
Contributor Author

/retest

@legionus
Copy link
Contributor Author

/retest

@legionus
Copy link
Contributor Author

/retest

@legionus
Copy link
Contributor Author

/retest

@legionus
Copy link
Contributor Author

/retest

@legionus
Copy link
Contributor Author

/retest

@legionus
Copy link
Contributor Author

/assign @dmage

@legionus
Copy link
Contributor Author

/retest

@dmage
Copy link
Member

dmage commented Apr 16, 2019

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2019
@legionus
Copy link
Contributor Author

/retest

2 similar comments
@legionus
Copy link
Contributor Author

/retest

@legionus
Copy link
Contributor Author

/retest

@legionus
Copy link
Contributor Author

legionus commented Apr 17, 2019 •
edited 

level=info msg="Waiting up to 30m0s for the cluster at https://api.ci-op-b6tbs5sy-12abb.origin-ci-int-aws.dev.rhcloud.com:6443 to initialize..."
level=fatal msg="failed to initialize the cluster: Cluster operator image-registry has not yet reported success: timed out waiting for the condition"
2019/04/17 09:20:53 Container setup in pod e2e-aws-operator failed, exit code 1, reason Error
Another process exited
2019/04/17 09:21:08 Container test in pod e2e-aws-operator failed, exit code 1, reason Error

...

level=fatal msg="failed to initialize the cluster: Cluster operator image-registry has not yet reported success: timed out waiting for the condition"

E0417 08:50:50.510454       1 reflector.go:134] github.com/openshift/client-go/config/informers/externalversions/factory.go:101: Failed to l
ist *v1.ClusterOperator: clusteroperators.config.openshift.io is forbidden: User "system:serviceaccount:openshift-image-registry:cluster-ima
ge-registry-operator" cannot list resource "clusteroperators" in API group "config.openshift.io" at the cluster scope

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2019
@legionus legionus added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2019
@legionus
Copy link
Contributor Author

/retest

1 similar comment
@legionus
Copy link
Contributor Author

/retest

@legionus legionus force-pushed the fix-cluster-operator-status-v1 branch from 194982e to 444688c Compare April 17, 2019 15:22
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2019
@legionus
Copy link
Contributor Author

/retest

2 similar comments
@legionus
Copy link
Contributor Author

/retest

@legionus
Copy link
Contributor Author

/retest

@legionus legionus force-pushed the fix-cluster-operator-status-v1 branch from 444688c to e614014 Compare April 24, 2019 11:48
@legionus
Copy link
Contributor Author

/retest

1 similar comment
@legionus
Copy link
Contributor Author

/retest

@legionus
Use generator for ClusterOperator
0408b09 
Signed-off-by: Gladkov Alexey <agladkov@redhat.com>
@legionus
Show changes in the objects
8eade45 
Signed-off-by: Gladkov Alexey <agladkov@redhat.com>
@legionus
Show changes in the custom resource
d752d97 
Signed-off-by: Gladkov Alexey <agladkov@redhat.com>
@legionus
Allow list resource "clusteroperators" in API group "config.openshift…
65ef942 
….io" at the cluster scope

Signed-off-by: Gladkov Alexey <agladkov@redhat.com>
@legionus legionus force-pushed the fix-cluster-operator-status-v1 branch from e614014 to 65ef942 Compare April 24, 2019 14:43
@dmage
Copy link
Member

dmage commented Apr 24, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, legionus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d8947f7 into openshift:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreydaley coreydaley Awaiting requested review from coreydaley

@dmage dmage Awaiting requested review from dmage

Assignees

@dmage dmage

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generate ClusterOperator's conditions using CR's conditions
4 participants
@legionus @dmage @openshift-ci-robot @openshift-merge-robot