Bug 1785115: tolerate all NoSchedule taints

[dmage]

/assign @adambkaplan

[openshift-ci-robot]

@dmage: This pull request references Bugzilla bug 1785115, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1785115: tolerate all NoSchedule taints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adambkaplan]

Since there's a BZ I'd like to see a test for this - either a unit test or an e2e. I can see the latter being a bit harder to pull off.

[dmage]

@adambkaplan do you want a unit test that checks that daemonset has a pod template spec with the same tolerations as we have it in the template?

[adambkaplan]

do you want a unit test that checks that daemonset has a pod template spec with the same tolerations as we have it in the template?

@dmage works for me. Per the kube docs, removing the key means the CA daemonset should schedule on every node [1]

[1] https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/

[dmage]

@adambkaplan ptal

[adambkaplan]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, dmage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adambkaplan,dmage]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@dmage: All pull requests linked via external trackers have merged. Bugzilla bug 1785115 has been moved to the MODIFIED state.

In response to this:

Bug 1785115: tolerate all NoSchedule taints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adambkaplan]

/cherrypick release-4.3

[adambkaplan]

/cherrypick release-4.2

[openshift-cherrypick-robot]

@adambkaplan: new pull request created: #472

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@adambkaplan: new pull request created: #473

In response to this:

/cherrypick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.