Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start using rolloutStrategy parameter #428

Merged
merged 1 commit into from Jan 15, 2020
Merged

Start using rolloutStrategy parameter #428

merged 1 commit into from Jan 15, 2020

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Jan 9, 2020 •
edited

This parameter allows to define rollout strategy for the image registry deployment.
Now support two possible rollout strategies: RollingUpdate (default) and Recreate.

The parameter was introduced by openshift/api#560

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 9, 2020
bparees
bparees reviewed Jan 9, 2020
View reviewed changes
pkg/resource/deployment.go Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 9, 2020
@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 9, 2020

/retest

@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 9, 2020

/test e2e-openstack

@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 9, 2020

/retest

1 similar comment
@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 10, 2020

/retest

@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 10, 2020

/test e2e-aws-operator

@adambkaplan
Copy link
Contributor

/hold

@coreydaley also needs an api (and client-go) bump to get his auto-pruner feature to land. We need to determine which goes first, or if one of creates a separate api/client-go bump PR.

/cc @dmage

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2020
@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 10, 2020

I suggest to create a separate PR with bump of api and client-go, and just keep the code in this one

@adambkaplan
Copy link
Contributor

@Fedosin looks like the API validation is breaking all of our tests. This will without question break customers on upgrade.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 13, 2020
@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 13, 2020

#432 should be merged first

@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 13, 2020

/retest

1 similar comment
@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 13, 2020

/retest

@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 13, 2020

/test images

@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 13, 2020

/hold cancel

@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 14, 2020

/retest

@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 14, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 14, 2020
dmage
dmage requested changes Jan 14, 2020
View reviewed changes
test/e2e/configuration_test.go Show resolved Hide resolved
manifests/registry-config.yaml Outdated Show resolved Hide resolved
test/e2e/configuration_test.go Outdated Show resolved Hide resolved
@Fedosin
Start using rolloutStrategy parameter
2351787 
This parameter allows to define rollout strategy for the image
registry deployment.

The parameter was introduced by:
openshift/api#560
@dmage
Copy link
Member

dmage commented Jan 14, 2020

/test e2e-aws-upgrade

@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 14, 2020

/test e2e-aws

@dmage
Copy link
Member

dmage commented Jan 15, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, Fedosin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 15, 2020

/test e2e-aws-operator

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 15, 2020

/test e2e-aws-operator

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 15, 2020

/test e2e-aws-operator

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@Fedosin Fedosin mentioned this pull request Jan 15, 2020
Merged
@openshift-merge-robot openshift-merge-robot merged commit d3894ac into openshift:master Jan 15, 2020
@Fedosin Fedosin mentioned this pull request Jan 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees bparees left review comments

@dmage dmage dmage requested changes

@coreydaley coreydaley Awaiting requested review from coreydaley

Assignees

@dmage dmage

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Fedosin @adambkaplan @dmage @openshift-ci-robot @openshift-bot @bparees @openshift-merge-robot