Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1803970: Creating ClusterOperator resource on ErrStorageNotConfigured #460

Merged
merged 1 commit into from Feb 18, 2020
Merged

Bug 1803970: Creating ClusterOperator resource on ErrStorageNotConfigured #460

merged 1 commit into from Feb 18, 2020

Conversation

ricardomaraschini
Copy link
Contributor

An ErrStorageNotConfigured should not block us from creating the
ClusterOperator resource.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 18, 2020
@ricardomaraschini ricardomaraschini changed the title Creating ClusterOperator resource on ErrStorageNotConfigured Bug 1803970: Creating ClusterOperator resource on ErrStorageNotConfigured Feb 18, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 18, 2020
@openshift-ci-robot
Copy link
Contributor

@ricardomaraschini: This pull request references Bugzilla bug 1803970, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1803970: Creating ClusterOperator resource on ErrStorageNotConfigured

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

An ErrStorageNotConfigured should not block us from creating the
ClusterOperator resource.
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 18, 2020
@dmage
Copy link
Member

dmage commented Feb 18, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2020
@ricardomaraschini
Copy link
Contributor Author

/retest

@stbenjam
Copy link
Member

stbenjam commented Feb 18, 2020

Thanks all, with this PR, image-registry comes up for me on baremetal:

NAME                                       VERSION                        AVAILABLE   PROGRESSING   DEGRADED   SINCE
image-registry                             4.4.0-0.ci-2020-02-18-102514   True        False         False      3m10s

@hardys
Copy link

hardys commented Feb 18, 2020

Thanks all, with this PR, image-registry comes up for me on baremetal:

+1 I also tested and in conjunction with openshift/installer#3117 IPI baremetal deployments are working again :)

@openshift-merge-robot openshift-merge-robot merged commit da8f959 into openshift:master Feb 18, 2020
@openshift-ci-robot
Copy link
Contributor

@ricardomaraschini: All pull requests linked via external trackers have merged. Bugzilla bug 1803970 has been moved to the MODIFIED state.

In response to this:

Bug 1803970: Creating ClusterOperator resource on ErrStorageNotConfigured

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dmage
Copy link
Member

dmage commented Mar 23, 2020

/cherrypick release-4.3

@openshift-cherrypick-robot

@dmage: #460 failed to apply on top of branch "release-4.3":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
A	pkg/operator/clusteroperator.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): pkg/operator/clusteroperator.go deleted in HEAD and modified in Creating ClusterOperator resource on ErrStorageNotConfigured. Version Creating ClusterOperator resource on ErrStorageNotConfigured of pkg/operator/clusteroperator.go left in tree.
Patch failed at 0001 Creating ClusterOperator resource on ErrStorageNotConfigured

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants