New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1806019: Enable --prune-registry flag #464
Conversation
/assign @adambkaplan @dmage |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: coreydaley The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retitle Bug 1806019: Enable --prune-registry flag |
@coreydaley: This pull request references Bugzilla bug 1806019, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coreydaley can you please add e2e tests that verify we pass in the correct --prune-registry
flag? We'll need one for Managed
and one for Removed
@adambkaplan test added |
Add tests for the --prune-registry flag
Updated the test to wait for the cronjob to get updated |
/retest |
@coreydaley: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/close |
@coreydaley: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Adds the --prune-registry flag to the oc admin command in the pruner cronjob based on the management state of the image registry custom resource