Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-grouping and re-ordering go imports #481

Merged
merged 1 commit into from Mar 5, 2020
Merged

Re-grouping and re-ordering go imports #481

merged 1 commit into from Mar 5, 2020

Conversation

coreydaley
Copy link
Member

Re-grouping and re-ordering go imports according to our team preferences:

  • standard
  • other
  • kubernetes
  • openshift
  • module

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 3, 2020
@coreydaley
Copy link
Member Author

/assign @dmage @ricardomaraschini

@coreydaley coreydaley changed the title Re-grouping and re-grouping go imports Re-grouping and re-ordering go imports Mar 3, 2020
dmage
dmage reviewed Mar 3, 2020
View reviewed changes
tools.go Outdated Show resolved Hide resolved
@coreydaley
Re-grouping go imports
e95b40b 
Re-grouping and re-ordering go imports according to our team preferences:
 - standard
 - other
 - kubernetes
 - openshift
 - module
@coreydaley
Copy link
Member Author

/refresh

@coreydaley
Copy link
Member Author

/retest

@ricardomaraschini
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2020
@coreydaley
Copy link
Member Author

/retest

@dmage
Copy link
Member

dmage commented Mar 4, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, dmage, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2020
@coreydaley
Copy link
Member Author

/retest

1 similar comment
@coreydaley
Copy link
Member Author

/retest

@coreydaley coreydaley mentioned this pull request Mar 4, 2020
Closed
@coreydaley
Copy link
Member Author

/retest

1 similar comment
@coreydaley
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 92fd21b into openshift:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmage dmage dmage left review comments

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@gabemontero gabemontero Awaiting requested review from gabemontero

Assignees

@dmage dmage

@ricardomaraschini ricardomaraschini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@coreydaley @ricardomaraschini @dmage @openshift-ci-robot @openshift-bot @openshift-merge-robot