Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.4] Bug 1810490: Ignore Swift backend if the user doesn't have required permissions #483

Merged
merged 1 commit into from Mar 5, 2020
Merged

[release-4.4] Bug 1810490: Ignore Swift backend if the user doesn't have required permissions #483

merged 1 commit into from Mar 5, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #465

/assign adambkaplan

@Fedosin
Bug 1806158: Ignore Swift backend if the user doesn't have required p…
9bd3ba2 
…ermissions

Now if Swift is available for OpenStack cloud, but the user doesn't have the
`swiftoperator` role, installation fails with either 403 or 401 error code from
Swift, depending on its configuration.

To prevent this we check if the user has this role, and if it's not the case
we fallback to RWO PVC backend.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 5, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1806158, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "4.5.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected Bugzilla bug 1806158 to depend on a bug targeting the "4.5.0" release and in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.4] Bug 1806158: Ignore Swift backend if the user doesn't have required permissions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 5, 2020
@adambkaplan
Copy link
Contributor

/retutle [release-4.4] Bug 1810490: Ignore Swift backend if the user doesn't have required permissions

@adambkaplan
Copy link
Contributor

/retitle [release-4.4] Bug 1810490: Ignore Swift backend if the user doesn't have required permissions

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] Bug 1806158: Ignore Swift backend if the user doesn't have required permissions [release-4.4] Bug 1810490: Ignore Swift backend if the user doesn't have required permissions Mar 5, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 5, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1810490, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.0) matches configured target release for branch (4.4.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1806158 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1806158 targets the "4.5.0" release, matching the expected (4.5.0) release
  • bug has dependents

In response to this:

[release-4.4] Bug 1810490: Ignore Swift backend if the user doesn't have required permissions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 5, 2020
@Fedosin
Copy link
Contributor

Fedosin commented Mar 5, 2020

/test e2e-aws

@dmage
Copy link
Member

dmage commented Mar 5, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2020
@openshift-merge-robot openshift-merge-robot merged commit 6516529 into openshift:release-4.4 Mar 5, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1810490 has been moved to the MODIFIED state.

In response to this:

[release-4.4] Bug 1810490: Ignore Swift backend if the user doesn't have required permissions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@coreydaley coreydaley Awaiting requested review from coreydaley

Assignees

@dmage dmage

@adambkaplan adambkaplan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @adambkaplan @Fedosin @dmage @openshift-merge-robot