Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait until operator is rolled out after its deployment is changed #508

Merged
merged 1 commit into from Apr 3, 2020

Conversation

dmage
Copy link
Member

@dmage dmage commented Apr 1, 2020

This should fix flakes when proxy environments leak into another test.

For example in https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-image-registry-operator/507/pull-ci-openshift-cluster-image-registry-operator-master-e2e-aws-operator/2524, TestImageRegistryGracefulShutdown:

          - lastTransitionTime: "2020-04-01T13:58:46Z"
            message: |-
              RequestError: send request failed
              caused by: Head https://ci-op-h5fdww49-12abb-grk4s-image-registry-us-west-2-vyoknhwswx.s3.dualstack.us-west-2.amazonaws.com/: proxyconnect tcp: dial tcp: lookup https.example.org on 172.30.0.10:53: no such host
            reason: Unknown Error Occurred
            status: Unknown
            type: StorageExists

@dmage
Copy link
Member Author

dmage commented Apr 1, 2020

/assign @ricardomaraschini @adambkaplan

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2020
Copy link
Contributor

@ricardomaraschini ricardomaraschini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2020
@ricardomaraschini
Copy link
Contributor

/test e2e-aws-image-registry

@ricardomaraschini
Copy link
Contributor

@dmage ops, seems like we have conflict.

@ricardomaraschini
Copy link
Contributor

/lgtm cancel

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2020
@dmage dmage force-pushed the proxy-flakes branch 4 times, most recently from 06ad9da to 89a1ffc Compare April 2, 2020 13:30
@dmage
Copy link
Member Author

dmage commented Apr 2, 2020

flake, should be fixed by #509
/test e2e-aws-operator

@dmage
Copy link
Member Author

dmage commented Apr 3, 2020

@ricardomaraschini ptal, I rebased and did some minor fixes

Copy link
Contributor

@ricardomaraschini ricardomaraschini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a925d0e into openshift:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants