New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait until operator is rolled out after its deployment is changed #508
Conversation
/assign @ricardomaraschini @adambkaplan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test e2e-aws-image-registry |
@dmage ops, seems like we have conflict. |
/lgtm cancel |
06ad9da
to
89a1ffc
Compare
flake, should be fixed by #509 |
@ricardomaraschini ptal, I rebased and did some minor fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmage, ricardomaraschini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
This should fix flakes when proxy environments leak into another test.
For example in https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-image-registry-operator/507/pull-ci-openshift-cluster-image-registry-operator-master-e2e-aws-operator/2524, TestImageRegistryGracefulShutdown: