New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1828608: Removing ImageRegistryRemoved alert #561
Bug 1828608: Removing ImageRegistryRemoved alert #561
Conversation
This is a condition considered normal as the administrator can remove the registry manually, we should not be alerting on such circunstances. Allied to that real problems with the Operator will be alerted by CVO.
@ricardomaraschini: This pull request references Bugzilla bug 1828608, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @dmage @adambkaplan |
Removing the alert seems sensible to me, i don't recall why we felt we needed one. Using emptydir storage seems potentially worth an alert, but registry being explicitly removed should be quite apparent the the admin if it's something they care about. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This is a "cause-based" alert, which is considered an anti-pattern. Telemetry can tell us which customers have removed the registry via the reason codes we added to the cluster operator.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, ricardomaraschini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@abhinavdahiya note that vSphere deployments will still need to configure registry storage on day 2. |
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@ricardomaraschini: All pull requests linked via external trackers have merged: openshift/cluster-image-registry-operator#561. Bugzilla bug 1828608 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Dear reviewer
In the past we have decided do bootstrap the registry as removed in some platforms, around the same time we also added an alert to notify the administrator if the registry was removed. Now we are having problems with some CI setup on VSphere(see related BZ) because the registry is bootstrapping as removed therefore this alarm is being triggered.
This PR removes this alert completely. Another option would be to postpone it to be triggered only a few hours later, please keep that in mind when reviewing this.
I have opted for removing this as the Registry being in a removed state is a "normal" situation, in the sense that any administrator may remove it by simply editing the config.