Enable registry by default for ovirt #583
Conversation
As part of the upcommig CSI Driver support a registry should be enabled by default. The CSI driver support is part of Cluster Storage Operator support in external providers. See openshift/enhancements#352 Signed-off-by: Roy Golan <rgolan@redhat.com>
|
This depends on oVirt csi operator support in CSO - I'll link the relevant PR. Merging this prematurely will fail ovirt e2e. |
openshift-ci-robot
added
the
do-not-merge/hold
|
@bennyz @Gal-Zaidman @gekorob please have a look |
|
/lgtm |
|
/assign @dmage |
| @@ -159,6 +158,11 @@ func GetPlatformStorage(listers *regopclient.Listers) (imageregistryv1.ImageRegi | |||
| Claim: defaults.PVCImageRegistryName, | |||
| } | |||
| replicas = 1 | |||
| case configapiv1.OvirtPlatformType: | |||
| cfg.PVC = &imageregistryv1.ImageRegistryConfigStoragePVC{ | |||
| Claim: defaults.PVCImageRegistryName, | |||
There was a problem hiding this comment.
When the claim name is present, the operator expects PVC to be provided.
| cfg.PVC = &imageregistryv1.ImageRegistryConfigStoragePVC{ | ||
| Claim: defaults.PVCImageRegistryName, | ||
| } | ||
| replicas = 1 |
There was a problem hiding this comment.
No - that would be a shared disk from RHV side. Do we have other options?
There was a problem hiding this comment.
I thought replica 1 would work with RWO?
There was a problem hiding this comment.
We want to have at least 2 replicas when it's possible. But in this case the operator can have only 1 replica, so it's ok.
There was a problem hiding this comment.
Noted. We would track this and use this case as a main driver for supporting RWX
|
Can you add e2e-ovirt (always_run: false, optional: true) to this repo so that we can check this change? |
This PR adds cluster-image-registry-operator e2e job for ovirt. requested in openshift/cluster-image-registry-operator#583 Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
created openshift/release#10437 |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
ovirt e2e won't pass because of the cluster storage operator work related to ovirt openshift/cluster-storage-operator#65 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmage, Gal-Zaidman, rgolangh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Before we had the CSI driver for ovirt [1] we needed to patch the image registry to use emptyDir storage. This patch removes the call for update_image_registry function on 4.6 and above. [1] openshift/cluster-image-registry-operator#583 openshift/cluster-storage-operator#65 Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
As part of the upcommig CSI Driver support a registry should be enabled by
default.
The CSI driver support is part of Cluster Storage Operator support in
external providers. See
openshift/enhancements#352
Signed-off-by: Roy Golan rgolan@redhat.com