Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.5] Bug 1880485: Retrying in case of conflict during Config update #613

Merged
merged 2 commits into from
Sep 26, 2020
Merged

[release-4.5] Bug 1880485: Retrying in case of conflict during Config update #613

merged 2 commits into from
Sep 26, 2020

Commits on Sep 18, 2020

  1. Retrying in case of conflict during Config update 

    We have multiple controllers concurrently writting the status of the
config, this commit introduces retries in case of any of them updated
the config resource before us. This is clearly a workaround, as the
main controller may create storage if we fail to update the
configuration here it may ended up creating storage again on the next
cycle, hence the need to make sure we succeed.
    @ricardomaraschini
    ricardomaraschini authored and openshift-cherrypick-robot committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    cd4e762 View commit details
    Browse the repository at this point in the history

  2. Adding test for failure on spec update 

    Added a test to check if operator is not failing to update the config
spec during bootstrap, if this failure happens it may end up creating
two storage units.
    @ricardomaraschini
    ricardomaraschini authored and openshift-cherrypick-robot committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    d65533f View commit details
    Browse the repository at this point in the history