Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.5] Bug 1916859: Sync status to spec with regards to Swift config #655

Closed
wants to merge 1 commit into from
Closed

[release-4.5] Bug 1916859: Sync status to spec with regards to Swift config #655

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #653

/assign ricardomaraschini

@ricardomaraschini
Sync status to spec with regards to Swift config
ad72b6c 
This commit makes Status.Storage.Swift to reflect Spec.Storage.Swift
when the provided container already exists. Prior to this status was
only kept in sync when the container was created.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 15, 2021
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1907202 has been cloned as Bugzilla bug 1916859. Retitling PR to link against new bug.
/retitle [release-4.5] Bug 1916859: Sync status to spec with regards to Swift config

In response to this:

[release-4.5] Bug 1907202: Sync status to spec with regards to Swift config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign dmage after the PR has been reviewed.
You can assign the PR to them by writing /assign @dmage in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] Bug 1907202: Sync status to spec with regards to Swift config [release-4.5] Bug 1916859: Sync status to spec with regards to Swift config Jan 15, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jan 15, 2021
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1916859, which is invalid:

  • expected dependent Bugzilla bug 1907202 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead
  • expected dependent Bugzilla bug 1907202 to target a release in 4.6.0, 4.6.z, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.5] Bug 1916859: Sync status to spec with regards to Swift config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 15, 2021
@ricardomaraschini
Copy link
Contributor

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2021

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-image-registry ad72b6c link /test e2e-aws-image-registry
ci/prow/e2e-aws ad72b6c link /test e2e-aws
ci/prow/unit ad72b6c link /test unit
ci/prow/verify ad72b6c link /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ricardomaraschini
Copy link
Contributor

/close

The original PR cannot be applied on top of release-4.5, I have created a different PR to address this at #656

@openshift-ci-robot
Copy link
Contributor

@ricardomaraschini: Closed this PR.

In response to this:

/close

The original PR cannot be applied on top of release-4.5, I have created a different PR to address this at #656

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreydaley coreydaley Awaiting requested review from coreydaley

@dmage dmage Awaiting requested review from dmage

Assignees

@ricardomaraschini ricardomaraschini

Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@openshift-cherrypick-robot @openshift-ci-robot @ricardomaraschini