Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support IBMCloud and add IBM COS storage driver #698

Merged
merged 1 commit into from Jul 4, 2021
Merged

feat: Support IBMCloud and add IBM COS storage driver #698

merged 1 commit into from Jul 4, 2021

Conversation

hasueki
Copy link
Contributor

@hasueki hasueki commented Jun 18, 2021 •
edited

This adds image-registry support for IBMCloud provider type and creates an IBM Cloud Object Storage as the registry storage backend. The operator will configure image-registry with appropriate S3 configurations.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot requested review from adambkaplan and dmage June 18, 2021 15:45
@hasueki hasueki mentioned this pull request Jun 18, 2021
Merged
dmage
dmage reviewed Jun 23, 2021
View reviewed changes
pkg/storage/ibmcos/ibmcos.go
serviceInstanceName := fmt.Sprintf("%s-%s", infra.Status.InfrastructureName, defaults.ImageRegistryName)
serviceTarget := "bluemix-global"
resourceGroupID := *resourceGroups.Resources[0].ID
resourcePlanID := "744bfc56-d12c-4866-88d5-dac9139e0e5d"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it some well-known ID?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is the COS service plan ID on IBM Cloud catalog.

@dmage
Copy link
Member

dmage commented Jun 29, 2021

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2021
@hasueki hasueki marked this pull request as ready for review June 29, 2021 12:20
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2021
@dmage
Copy link
Member

dmage commented Jun 30, 2021

/retest

@hasueki hasueki requested a review from dmage July 1, 2021 17:25
@xiuwang
Copy link

xiuwang commented Jul 2, 2021

Test installation on aws,gcp,azure with the pr, the image registry works well, no regression issue.
When IBM cloud installation is ready, I will check the image registry storage with IBM cloud backend.

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 2, 2021
@dmage
Copy link
Member

dmage commented Jul 2, 2021

@hasueki api changes has landed, so you can remove replace. I guess it's better to squash these commits and we can merge this.

@hasueki
feat: Support IBMCloud and add IBM COS storage driver
8614d04 
feat(ibmcloud): Set storage platform in Config

feat(ibmcos): Storage driver scaffolding

feat(ibmcos): Implement StorageChanged()

feat(ibmcos): Implement StorageExists()

feat(ibmcos): Implement CreateStorage()

feat(ibmcos): Implement ConfigEnv()

feat(ibmcos): Implement VolumeSecrets()

feat(ibmcos): Implement Volumes()

feat(ibmcos): Implement ID()

feat(ibmcos): Implement RemoveStorage()

feat(ibmcos): Set configs and credentials for image-registry

chore(ibmcos): Tweak comments

fix(deps): Update openshift/api version

test(ibmcos): Add unit test for ConfigEnv()

test(ibmcos): Add unit test for ManagementState

fix(deps): Update openshift/api version

fix(ibmcos): Set anonymous creds for tests

feat(ibmcos): Add credentials request

chore: Update go deps
@hasueki
Copy link
Contributor Author

hasueki commented Jul 2, 2021

@dmage openshift/api updated in go.mod and commits squashed.

@dmage
Copy link
Member

dmage commented Jul 3, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, hasueki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a02a9e7 into openshift:master Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@dmage dmage Awaiting requested review from dmage

Assignees

@dmage dmage

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hasueki @dmage @xiuwang @openshift-bot @openshift-merge-robot