Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCO-105: Support gcp workload identity federation #702

Conversation

akhil-rane
Copy link
Contributor

@akhil-rane akhil-rane commented Jun 30, 2021

To enable short-lived credentials in gcp cluster using workload identity
federation (similar to AWS STS), we need to make following set of changes

  • update golang.org/x/oauth2 to a version that supports workload identity
  • add kubernetes service account names to gcp credentials request manifest
    which can be used by ccoctl tool to create gcp service accounts with
    limited access

ref: https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity
x-ref: https://issues.redhat.com/browse/CCO-105

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2021
@openshift-ci openshift-ci bot requested review from bparees and dmage June 30, 2021 15:07
gopkg.in/yaml.v2 v2.4.0
k8s.io/api v0.21.0
k8s.io/apimachinery v0.21.0
k8s.io/client-go v0.21.0
k8s.io/klog/v2 v2.8.0
k8s.io/utils v0.0.0-20210305010621-2afb4311ab10
)

replace google.golang.org/grpc => google.golang.org/grpc v1.29.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you use the latest version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github.com/openshift/library-go has hard dependency on this version

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2021
@akhil-rane akhil-rane force-pushed the support_gcp_workload_identity branch from 8c87905 to ddc1da8 Compare July 6, 2021 18:49
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2021
For enabling short-lived credentials in gcp cluster using workload
identity, we need ccoctl tool to know the kubernetes service account
names from the credentials request manifest so that it can create
gcp service accounts that can be impersonated only by specific
kubernetes service accounts.
@akhil-rane akhil-rane force-pushed the support_gcp_workload_identity branch from ddc1da8 to f84bbd3 Compare July 7, 2021 15:40
@akhil-rane akhil-rane changed the title WIP: Support gcp workload identity federation Support gcp workload identity federation Jul 20, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2021
@akhil-rane
Copy link
Contributor Author

@dmage this looks good for a review. PTAL

@dmage
Copy link
Member

dmage commented Jul 20, 2021

@akhil-rane do you have a Jira issue for this?

@akhil-rane
Copy link
Contributor Author

@akhil-rane do you have a Jira issue for this?

yep https://issues.redhat.com/browse/CCO-105

@dmage
Copy link
Member

dmage commented Jul 23, 2021

/retitle CCO-105: Support gcp workload identity federation

@openshift-ci openshift-ci bot changed the title Support gcp workload identity federation CCO-105: Support gcp workload identity federation Jul 23, 2021
@dmage
Copy link
Member

dmage commented Jul 23, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhil-rane, dmage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2021

@akhil-rane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-operator f84bbd3 link /test e2e-gcp-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit df79e1c into openshift:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants