New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCO-105: Support gcp workload identity federation #702
CCO-105: Support gcp workload identity federation #702
Conversation
gopkg.in/yaml.v2 v2.4.0 | ||
k8s.io/api v0.21.0 | ||
k8s.io/apimachinery v0.21.0 | ||
k8s.io/client-go v0.21.0 | ||
k8s.io/klog/v2 v2.8.0 | ||
k8s.io/utils v0.0.0-20210305010621-2afb4311ab10 | ||
) | ||
|
||
replace google.golang.org/grpc => google.golang.org/grpc v1.29.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you use the latest version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github.com/openshift/library-go
has hard dependency on this version
8c87905
to
ddc1da8
Compare
For enabling short-lived credentials in gcp cluster using workload identity, we need ccoctl tool to know the kubernetes service account names from the credentials request manifest so that it can create gcp service accounts that can be impersonated only by specific kubernetes service accounts.
ddc1da8
to
f84bbd3
Compare
@dmage this looks good for a review. PTAL |
@akhil-rane do you have a Jira issue for this? |
|
/retitle CCO-105: Support gcp workload identity federation |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akhil-rane, dmage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@akhil-rane: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest-required Please review the full test history for this PR and help us cut down flakes. |
To enable short-lived credentials in gcp cluster using workload identity
federation (similar to AWS STS), we need to make following set of changes
which can be used by ccoctl tool to create gcp service accounts with
limited access
ref: https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity
x-ref: https://issues.redhat.com/browse/CCO-105