New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start using embed for assets #703
Conversation
/test e2e-aws-operator |
/retest |
/approve |
/retest |
In go 1.16 they introduced embed module that allows to inject assets in the binary automatically. With this module we don't need to generate code using go-bindata anymore, which means this library can be safely removed.
/test e2e-aws-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmage, Fedosin, ricardomaraschini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In go 1.16 they introduced embed module that allows to inject assets in the binary automatically. With this module we don't need to generate code using go-bindata anymore, which means this library can be safely removed.