Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1982611: bump aws-sdk-go to v1.38.35 #706

Merged
merged 2 commits into from Aug 4, 2021
Merged

Bug 1982611: bump aws-sdk-go to v1.38.35 #706

merged 2 commits into from Aug 4, 2021

Conversation

dmage
Copy link
Member

@dmage dmage commented Jul 20, 2021

No description provided.

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2021

@dmage: This pull request references Bugzilla bug 1982611, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1977159 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1977159 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @wzheng1

In response to this:

Bug 1982611: bump aws-sdk-go to v1.38.35

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from wzheng1 July 20, 2021 12:19
@dmage
Copy link
Member Author

dmage commented Jul 20, 2021

/assign @ricardomaraschini
/retest

@wewang58
Copy link

Needs to update registry.svc.ci.openshift.org/ocp/builder image in https://github.com/dmage/cluster-image-registry-operator/blob/bump-aws-4.6/Dockerfile#L1

@sdodson
Copy link
Member

sdodson commented Jul 30, 2021

@ricardomaraschini PTAL, also see @wewang58 comment about needing to update the Dockerfile

ricardomaraschini
ricardomaraschini approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@ricardomaraschini ricardomaraschini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dmage,ricardomaraschini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@ecordell
Copy link

ecordell commented Aug 4, 2021

[patch-manager] 🚀 Approved for z-stream by score: 0.20

picked

@ecordell ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 4, 2021
@openshift-ci openshift-ci bot mentioned this pull request Aug 4, 2021
Merged
@openshift-ci openshift-ci bot merged commit 7d7a7ac into openshift:release-4.6 Aug 4, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2021

@dmage: All pull requests linked via external trackers have merged:

Bugzilla bug 1982611 has been moved to the MODIFIED state.

In response to this:

Bug 1982611: bump aws-sdk-go to v1.38.35

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardomaraschini ricardomaraschini ricardomaraschini approved these changes

@bparees bparees Awaiting requested review from bparees

@wzheng1 wzheng1 Awaiting requested review from wzheng1

Assignees

@ricardomaraschini ricardomaraschini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dmage @wewang58 @sdodson @openshift-bot @ecordell @ricardomaraschini