Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2082492: IBMCloud: Add admin permissions to CR #776

Merged
merged 1 commit into from May 10, 2022

Conversation

cjschaef
Copy link
Member

@cjschaef cjschaef commented May 9, 2022

IBM Cloud COS now requires access to Admin level role in order to
access COS HMAC keys during image-registry COS resource creation.

Related: https://bugzilla.redhat.com/show_bug.cgi?id=2082492

IBM Cloud COS now requires access to Admin level role in order to
access COS HMAC keys during image-registry COS resource creation.

Related: https://bugzilla.redhat.com/show_bug.cgi?id=2082492
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 9, 2022

@cjschaef: This pull request references Bugzilla bug 2082492, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @xiuwang

In response to this:

Bug 2082492: IBMCloud: Add admin permissions to CR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MayXuQQ
Copy link

MayXuQQ commented May 10, 2022

based on 4.10.0-0.nightly-2022-05-09-181826 pre-merge test success

@dmage
Copy link
Member

dmage commented May 10, 2022

/lgtm
/cherrypick release-4.10

@openshift-cherrypick-robot

@dmage: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you.

In response to this:

/lgtm
/cherrypick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjschaef, dmage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@xiuwang
Copy link

xiuwang commented May 10, 2022

/label qe-approved
Test along with openshift/cluster-cloud-controller-manager-operator/pull/189, the image registry could be installed during installataion.
Could push or pull image to the image registry.

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2022

@cjschaef: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 66ddfc9 into openshift:master May 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2022

@cjschaef: All pull requests linked via external trackers have merged:

Bugzilla bug 2082492 has been moved to the MODIFIED state.

In response to this:

Bug 2082492: IBMCloud: Add admin permissions to CR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@dmage: new pull request created: #778

In response to this:

/lgtm
/cherrypick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cjschaef
Copy link
Member Author

/cherry-pick release-4.10

@openshift-cherrypick-robot

@cjschaef: new pull request could not be created: failed to create pull request against openshift/cluster-image-registry-operator#release-4.10 from head openshift-cherrypick-robot:cherry-pick-776-to-release-4.10: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-776-to-release-4.10."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants