Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPVE-632: add capability annotations to manifests #856

Merged
merged 1 commit into from Aug 30, 2023
Merged

OCPVE-632: add capability annotations to manifests #856

merged 1 commit into from Aug 30, 2023

Conversation

qJkee
Copy link
Contributor

@qJkee qJkee commented May 23, 2023

Add capability annotation to manifests to make image registry optional

@openshift-ci openshift-ci bot requested review from dmage and flavianmissi May 23, 2023 17:03
@flavianmissi
Copy link
Member

Thanks for this @qJkee. Could you look at the test failures?
Additionally, it seems you changed a file that is auto-generated (that's why the verify job is failing).

@qJkee qJkee force-pushed the CNF-5647-make-image-registry-optional branch from fa42e0f to b733d35 Compare June 26, 2023 11:30
@qJkee
Copy link
Contributor Author

qJkee commented Jun 26, 2023

@flavianmissi
Fixed!
The rest of the tests would be working once the installer and CVO will know about this capability

@flavianmissi
Copy link
Member

flavianmissi commented Jun 26, 2023 •
edited

thank you @qJkee !

The rest of the tests would be working once the installer and CVO will know about this capability

Gotcha. Is the plan to change installer and CVO before merging this PR?

@flavianmissi
Copy link
Member

Also - do we need resources created at runtime by the operator to also have this capability? I'm assuming we don't need that but want to confirm.

@qJkee
Copy link
Contributor Author

qJkee commented Jun 26, 2023

@flavianmissi
They can be merged once we run the tests and confirm that the cluster working without the image registry
Before that, api PR won't be accepted.

No, just the install manifests because they disable the operator completely

@flavianmissi
Copy link
Member

should we put this PR on hold then to signalize that we are waiting?

@qJkee qJkee changed the title [CNF-5647] add capability annotations to manifests CNF-9386: add capability annotations to manifests Aug 3, 2023
@qJkee
Copy link
Contributor Author

qJkee commented Aug 14, 2023

/hold until we merge cap name to CVO
Before that, tests will fail

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2023
flavianmissi
flavianmissi reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@flavianmissi flavianmissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the manifests/01-registry-credentials-request-powervs.yaml file also need to get the capabilities annotation?
Looks good otherwise

@qJkee
Copy link
Contributor Author

qJkee commented Aug 15, 2023

I think yes, because in spec it has secretRef to namespace which we annotate too.

@flavianmissi
Copy link
Member

/retest

1 similar comment
@qJkee
Copy link
Contributor Author

qJkee commented Aug 16, 2023

/retest

@qJkee
Copy link
Contributor Author

qJkee commented Aug 16, 2023

Ci is not doing well
/retest-required

@qJkee
Copy link
Contributor Author

qJkee commented Aug 16, 2023

/jira-refresh

@xiuwang
Copy link

xiuwang commented Aug 16, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 16, 2023
@qJkee qJkee force-pushed the CNF-5647-make-image-registry-optional branch from b733d35 to 107e74e Compare August 16, 2023 09:15
@qJkee
Copy link
Contributor Author

qJkee commented Aug 16, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2023
@flavianmissi
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi, qJkee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@flavianmissi
Copy link
Member

/retest

@stevsmit
Copy link
Member

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Aug 16, 2023
@flavianmissi
Copy link
Member

/test e2e-aws-operator

@davemulford
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Aug 16, 2023
@qJkee
Copy link
Contributor Author

qJkee commented Aug 16, 2023

/hold because of #899

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2023
@qJkee
Copy link
Contributor Author

qJkee commented Aug 23, 2023

/retest

@qJkee qJkee changed the title CNF-9386: add capability annotations to manifests OCPBUGS-17806: add capability annotations to manifests Aug 23, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 23, 2023
@openshift-ci-robot
Copy link
Contributor

@qJkee: This pull request references Jira Issue OCPBUGS-17806, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add capability annotation to manifests to make image registry optional

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qJkee qJkee changed the title OCPBUGS-17806: add capability annotations to manifests OCPVE-632: add capability annotations to manifests Aug 25, 2023
@openshift-ci-robot openshift-ci-robot removed the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 25, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 25, 2023 •
edited by openshift-ci bot

@qJkee: This pull request references OCPVE-632 which is a valid jira issue.

In response to this:

Add capability annotation to manifests to make image registry optional

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flavianmissi
Copy link
Member

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Aug 29, 2023
@qJkee
Copy link
Contributor Author

qJkee commented Aug 29, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 37b7319 and 2 for PR HEAD 107e74e in total

@qJkee
Copy link
Contributor Author

qJkee commented Aug 29, 2023

/test e2e-hypershift

@qJkee
Copy link
Contributor Author

qJkee commented Aug 29, 2023

/retest

@wking
Copy link
Member

wking commented Aug 30, 2023

e2e-aws-operator run failed on a build-cluster hiccup.

/retest-required

@flavianmissi
Copy link
Member

flavianmissi commented Aug 30, 2023 •
edited

same failure as previous
/retest-required

@qJkee
Copy link
Contributor Author

qJkee commented Aug 30, 2023

/retest-required

@flavianmissi
Copy link
Member

test failure seems unrelated
/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2023

@qJkee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ovirt-sdn b733d35 link false /test e2e-ovirt-sdn
ci/prow/e2e-openstack 107e74e link false /test e2e-openstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4d68ce9 into openshift:master Aug 30, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavianmissi flavianmissi flavianmissi left review comments

@dmage dmage Awaiting requested review from dmage

Assignees

@flavianmissi flavianmissi

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@qJkee @flavianmissi @xiuwang @stevsmit @davemulford @openshift-ci-robot @wking @openshift-merge-robot