Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE-682 : Update openshift/api package to latest version #887

Merged
merged 2 commits into from Aug 8, 2023
Merged

CFE-682 : Update openshift/api package to latest version #887

merged 2 commits into from Aug 8, 2023

Conversation

bharath-b-rh
Copy link
Contributor

PR is for updating the openshift/api package to the latest version which contains the API changes for supporting GCP labels & tags made in openshift/api#1445

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@bharath-b-rh
Copy link
Contributor Author

/hold openshift/api#1445

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2023
@jianli-wei
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 4, 2023
@bharath-b-rh
Copy link
Contributor Author

/remove-hold

@bharath-b-rh bharath-b-rh marked this pull request as ready for review August 5, 2023 15:24
@openshift-ci openshift-ci bot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 5, 2023
@flavianmissi
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharath-b-rh, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 09e6457 and 2 for PR HEAD 32c54f7 in total

@flavianmissi
Copy link
Member

/retest-required

@bharath-b-rh
Copy link
Contributor Author

/docs-approved
/px-approved

@bharath-b-rh
Copy link
Contributor Author

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Aug 7, 2023
@bharath-b-rh
Copy link
Contributor Author

/jira-refresh

@bharath-b-rh
Copy link
Contributor Author

/test e2e-aws-operator

@bharath-b-rh
Copy link
Contributor Author

/test e2e-aws-operator

@bharath-b-rh
Copy link
Contributor Author

/test e2e-vsphere-operator

1 similar comment
@bharath-b-rh
Copy link
Contributor Author

/test e2e-vsphere-operator

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2023

@bharath-b-rh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ovirt-sdn 32c54f7 link false /test e2e-ovirt-sdn
ci/prow/e2e-vsphere 32c54f7 link false /test e2e-vsphere
ci/prow/e2e-azure-operator 32c54f7 link false /test e2e-azure-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5305777 into openshift:master Aug 8, 2023
14 of 17 checks passed
@bharath-b-rh bharath-b-rh deleted the cfe-682-api branch August 8, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmage dmage Awaiting requested review from dmage

@flavianmissi flavianmissi Awaiting requested review from flavianmissi

Assignees

@flavianmissi flavianmissi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bharath-b-rh @jianli-wei @flavianmissi @openshift-ci-robot @openshift-merge-robot